Closed
Bug 1276175
Opened 8 years ago
Closed 8 years ago
TEST-UNEXPECTED-FAIL | test_ssl_disabled_error_page.py TestSSLDisabledErrorPage.test_ssl_disabled_error_page | AssertionError: False is not true
Categories
(Testing :: Firefox UI Tests, defect)
Tracking
(firefox49 fixed)
RESOLVED
FIXED
mozilla49
| Tracking | Status | |
|---|---|---|
| firefox49 | --- | fixed |
People
(Reporter: whimboo, Assigned: whimboo)
References
Details
(Keywords: intermittent-failure, regression)
Attachments
(2 files)
screenshot.png
A new regression for our tests as introduced by the merge from m-c into inbound: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?changeset=49beae1792077eba5b790baa7d3c1a37ca3eb609 https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&filter-searchStr=Firefox%20UI&filter-tier=2&filter-tier=3&fromchange=94033f5e655567162a397af1f48a3bf00e884421&selectedJob=28806006 17:17:25 INFO - TEST-UNEXPECTED-FAIL | test_ssl_disabled_error_page.py TestSSLDisabledErrorPage.test_ssl_disabled_error_page | AssertionError: False is not true 17:17:25 INFO - Traceback (most recent call last): 17:17:25 INFO - File "/home/worker/workspace/build/venv/local/lib/python2.7/site-packages/marionette/marionette_test.py", line 344, in run 17:17:25 INFO - testMethod() 17:17:25 INFO - File "/home/worker/workspace/build/tests/firefox-ui/tests/functional/security/test_ssl_disabled_error_page.py", line 43, in test_ssl_disabled_error_page 17:17:25 INFO - self.assertTrue(try_again_button.is_displayed())
|
Assignee | |
Comment 1•8 years ago
|
||
Actually it was the merge from fx-team: https://hg.mozilla.org/mozilla-central/pushloghtml?changeset=b0096c5c727749ad3e79cbdf20d2e96bd179c213 Started to permfail with this changeset: https://treeherder.mozilla.org/#/jobs?repo=fx-team&filter-searchStr=Firefox%20UI&filter-tier=2&filter-tier=3&fromchange=784c52abffb3e8ec4135b999369c23552a5239d9&selectedJob=9551956 Looks that bug 1273696 regressed it.
|
|
Assignee | |
Comment 2•8 years ago
|
||
When we run our tests there is no try again button. But when I do the steps locally I see it. Will dig into for investigation.
|
|
Assignee | |
Comment 3•8 years ago
|
||
Ok, so we should check the reset prefs button now. We can even do a click on it and verify that the page gets loaded correctly afterward. I will have a patch ready soon.
|
||
Comment 4•8 years ago
|
||
Hey Henry, Sorry I wasn't aware of this test. The test should probably check for both instances as depending on a users preferences the code will hide the try button. Let me know if you need more details!
|
|
||
Comment 5•8 years ago
|
||
*Henrik sorry!
|
|
Assignee | |
Comment 6•8 years ago
|
||
If SSL related preferences have been changed the retry button is no longer shown. Instead you see a button to reset the preferences, and which will reload the page. Review commit: https://reviewboard.mozilla.org/r/55798/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/55798/
Attachment #8757282 -
Flags: review?(mjzffr)
Comment on attachment 8757282 [details] MozReview Request: Bug 1276175 - Check the new reset prefs button for a disabled SSL error page. r?maja_zf https://reviewboard.mozilla.org/r/55798/#review52442
Attachment #8757282 -
Flags: review?(mjzffr) → review+
| Comment hidden (Intermittent Failures Robot) |
| Comment hidden (Intermittent Failures Robot) |
|
||
Comment 11•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/0fe273ea18a7
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
| Comment hidden (Intermittent Failures Robot) |
You need to log in
before you can comment on or make changes to this bug.
Description
•