127673 - Mozilla does not strip dquotes from filename on Content-Disposition: line

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Mark Lord]

When downloading a file which includes a Content-Disposition: line in the HTTP
header, mozilla fails to remove the outer dquote (") characters from around the
filename, resulting in the file being saved with the dquote (") characters as
part of the name.  This is non-compliant with RFC 1806.

Example:

HTTP/1.1 200 OK
Connection: close
Accept-Ranges: bytes
Content-Length: 2638959
Content-Type: audio/mpeg
Content-Disposition: attachment; filename="Al Simmons - Gypsy Sock.mp3"

...file data follows here...

Comment 1

[Boris Zbarsky [:bzbarsky]]

Reporter, what build are you using?  I thought fixed this on Jan 23 (see bug
121509).

Is there a particular site that exhibits this problem?

Comment 2

[Mark Lord]

The About::Mozilla screen says this:

Mozilla 0.9.7+
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.7+) Gecko/20020121

Note that this is not exactly the same as bug 121509; the file here *is* picked
up and used, but the dquotes are not discarded.  I cannot retest with 0.9.8
because that version just mysteriously closes windows when trying to access web
sites.. but that's a different bug.  :)

If already fixed, then Good!

Comment 3

[Boris Zbarsky [:bzbarsky]]

Right.  The bug summary there does not list this problem, but I fixed it in the
patch (if you look I added a regexp to strip out the quotes).

Marking this fixed (I can't reproduce the issue in current builds, in addition
to knowing that the code is in place), but please retest with 0.9.9 when that
comes out (probably a week or so from now) and either verify or reopen.

Thanks,
Boris

Comment 4

[Mark Lord]

Unable to retest on 0.9, due to a NEW mozilla bug (damnit!).

Comment 5

[Boris Zbarsky [:bzbarsky]]

Um... which new bug, exactly?

Comment 6

[Mark Lord]

Okay, other problem now fixed, this one retested, and..

All is well.  Thanks guys!