1276972 - Add value and attributes caching tests.

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Comment 1

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: Bug 1276972 - adding value and attributes caching tests.

Review commit: https://reviewboard.mozilla.org/r/56604/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/56604/

Comment 2

[Yura Zenevich [:yzen] (please use "needinfo")]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=35aafb436cd3

Comment 3

[Eitan Isaacson [:eeejay]]

Comment on attachment 8758324 [details]
Bug 1276972 - adding value and attributes caching tests.

https://reviewboard.mozilla.org/r/56604/#review53712

A few questions below. Thanks!

::: accessible/tests/browser/browser_caching_attributes.js:61
(Diff revision 1)
> +  unexpected: {
> +    'container-live': 'polite',
> +    'live': 'polite'
> +  }
> +}, {
> +  desc: '@id attribute changes, attributes should get updated',

Will this reliably pass all the time? Not waiting for an event makes me nervous.

::: accessible/tests/browser/browser_caching_attributes.js:75
(Diff revision 1)
> +  unexpected: {
> +    'container-live': 'polite',
> +    'live': 'polite'
> +  }
> +}, {
> +  desc: '@aria-live sets container-live and live attributes',

Same, no event. How will this remain reliable?

::: accessible/tests/browser/browser_caching_value.js:72
(Diff revision 1)
> +  desc: 'Value should change when @aria-valuetext is updated',
> +  id: 'slider',
> +  attrs: [{
> +    attr: 'aria-valuenow'
> +  }],
> +  expected: ['hey!', 0, 0, 7, 0]

This is an interesting case, valuetext doesn't change, valuenow does, and you don't get an EVENT_VALUE_CHANGE? I would think that is a bug.

Comment 4

[Yura Zenevich [:yzen] (please use "needinfo")]

(In reply to Eitan Isaacson [:eeejay] from comment #3)
> Comment on attachment 8758324 [details]
> MozReview Request: Bug 1276972 - adding value and attributes caching tests.
> r=eeejay
>
> ...
>
> ::: accessible/tests/browser/browser_caching_value.js:72
> (Diff revision 1)
> > +  desc: 'Value should change when @aria-valuetext is updated',
> > +  id: 'slider',
> > +  attrs: [{
> > +    attr: 'aria-valuenow'
> > +  }],
> > +  expected: ['hey!', 0, 0, 7, 0]
> 
> This is an interesting case, valuetext doesn't change, valuenow does, and
> you don't get an EVENT_VALUE_CHANGE? I would think that is a bug.

Here value does not change, what does is nsIAccessibleValue::currentValue in cases were accessible supports nsIAccessibleValue interface.

Comment 5

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8758324 [details]
Bug 1276972 - adding value and attributes caching tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/56604/diff/1-2/

Comment 6

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8758324 [details]
Bug 1276972 - adding value and attributes caching tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/56604/diff/2-3/

Comment 7

[Eitan Isaacson [:eeejay]]

Comment on attachment 8758324 [details]
Bug 1276972 - adding value and attributes caching tests.

https://reviewboard.mozilla.org/r/56604/#review54516

::: accessible/tests/browser/browser_caching_attributes.js:68
(Diff revisions 1 - 2)
>    attrs: [{
>      attr: 'aria-live',
>      value: 'polite'
> +  }, {
> +    // Additionally triggering NAME_CHANGE event to make sure there are no
> +    // intermittents.

I think this is even more problematic. The change alters the actual test. I would keep it the way it is (no waitFor).

But more generally, I think it is a bug that there is no event when the numeric value changes if there is a text value.

Comment 8

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8758324 [details]
Bug 1276972 - adding value and attributes caching tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/56604/diff/3-4/

Comment 9

[Yura Zenevich [:yzen] (please use "needinfo")]

(In reply to Yura Zenevich [:yzen] from comment #8)
> Comment on attachment 8758324 [details]
> Bug 1276972 - adding value and attributes caching tests.
> 
> Review request updated; see interdiff:
> https://reviewboard.mozilla.org/r/56604/diff/3-4/

OK, moved things back when there were no events ?

Comment 10

[Eitan Isaacson [:eeejay]]

Comment on attachment 8758324 [details]
Bug 1276972 - adding value and attributes caching tests.

https://reviewboard.mozilla.org/r/56604/#review55100

Comment 11

[Yura Zenevich [:yzen] (please use "needinfo")]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1357e6366168

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b107bbf2a067
adding value and attributes caching tests. r=eeejay

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b107bbf2a067