Closed Bug 127698 Opened 23 years ago Closed 22 years ago

Save button does not come up when opening file from Windows Explorer

Categories

(SeaMonkey :: Composer, defect)

Product:
SeaMonkey
Component:
Composer
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla1.0

People

(Reporter: sujay, Assigned: cmanske)

References

Details

(Whiteboard: EDITORBASE QAHP)

Attachments

(1 file, 3 obsolete files)

New fix
2.78 KB, patch
Brade
: review+
kinmoz
: superreview+
asa
: approval+
Details | Diff | Splinter Review 
using 2/25 build of windows

1) create an HTML file on your desktop
2) launch Windows Explorer
3) right click on that HTML file and choose "Edit"

the file gets loaded into a composer window, but there is no
Save button on toolbar! You are forced to use "Save As".
I am seeing this problem on Win 2k using the 02-25 trunk build as well.
Attached patch Fix (obsolete) — — Splinter Review 
Side effect of recent publish UI changes.
This calls method that sets save/publish UI
during editor's onload command.
Status: NEW → ASSIGNED
Keywords: nsbeta1+, patch, review
Whiteboard: FIX IN HAND, needr=,sr=
Target Milestone: --- → mozilla1.0
Is plain text editor also broken?  Do we need to address that case?
*** Bug 127738 has been marked as a duplicate of this bug. ***
Comment on attachment 71332 [details] [diff] [review]
Fix

should have shown more context. This is in
function EditorOnLoad()

        Attachment #71332 -
        Attachment is obsolete: true

    
    

    
  
Comment on attachment 71550 [details] [diff] [review]
Update: Need to put same call in TextEditorOnLoad()

url is not defined in TextEditorOnLoad

        Attachment #71550 -
        Flags: needs-work+

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Update. (obsolete)
        — 
          — Splinter Review
      

    


  
Of course it helps to get it right.

        Attachment #71550 -
        Attachment is obsolete: true

    
    

    
  
Comment on attachment 71558 [details] [diff] [review]
Update.

r=brade

        Attachment #71558 -
        Flags: review+

    
    

    
  
Comment on attachment 71558 [details] [diff] [review]
Update.

sr=sfraser

        Attachment #71558 -
        Flags: superreview+

    
    

    
  
lets get this fix in...

    
    

    
  
I'll try or 0.9.9
Target Milestone: mozilla1.0 → mozilla0.9.9

    
    

    
  
Comment on attachment 71558 [details] [diff] [review]
Update.

a=asa (on behalf of drivers) for checkin to 0.9.9 and the trunk

        Attachment #71558 -
        Flags: approval+

    
  
Whiteboard: FIX IN HAND, needr=,sr= → FIX IN HAND reviewed

    
    

    
  
checked into both trunk and 0.9.9 branch


Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Keywords: patch, 
          
            review
Resolution: --- → FIXED
Whiteboard: FIX IN HAND reviewed

    
    

    
  
I am still seeing this problem on today's trunk build (03-04) on Win XP.

I am reopening this bug.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

    
    

    
  
Do you see the Publish button instead?


    
    

    
  
Also, what is the URL of the file: from the window caption and from Format |
Page Title and Properties dialog).


    
    

    
  
Yes, I see a publish button instead.

The title bar lists the file as:  asdf (file:/.../asdf.html) - Composer
Format - Page Title and Properties lists the file as:  file:///C:/Documents%
20and%20Settings/QA%20Tester/Desktop/asdf.html

    
  
Whiteboard: EDITORBASE QAHP

    
    

    
  

      
      
      
      

        Attached patch
          
          
        New fix
        — 
          — Splinter Review
      

    


  
So the problem is the "file" scheme isn't being detected because initial URL is

a local Windows filepath, which is totally legal. The new fix does this:
1. Removes calls to SetSaveAndPublishUI() from the editor's onload handlers and

from EditorStartup code. It's too early to call then.
2. Call SetSaveAndPublishUI() in the NotifyDocumentCreated callback; at this
time, we can get the document URL, which will be converted to "file://..." 
format.
3. Change editorOverlay.xul to initially hide the Publish button so the Save
button displays during document loading. When finished, SetSaveAndPublishUI
switches to the Publish button (when appropriate) without jiggling the toolbar.

        Attachment #71558 -
        Attachment is obsolete: true

    
  
Status: REOPENED → ASSIGNED
Whiteboard: EDITORBASE QAHP → EDITORBASE QAHP, FIX IN HAND, need r=,sr=
Target Milestone: mozilla0.9.9 → mozilla1.0

    
    

    
  
Comment on attachment 72652 [details] [diff] [review]
New fix

r=brade

        Attachment #72652 -
        Flags: review+

    
  
Whiteboard: EDITORBASE QAHP, FIX IN HAND, need r=,sr= → EDITORBASE QAHP, FIX IN HAND, need sr=

    
    

    
  
Comment on attachment 72652 [details] [diff] [review]
New fix

sr=kin@netscape.com

        Attachment #72652 -
        Flags: superreview+

    
  
Whiteboard: EDITORBASE QAHP, FIX IN HAND, need sr= → EDITORBASE QAHP, FIX IN HAND, reviewed

    
    

    
  
Comment on attachment 72652 [details] [diff] [review]
New fix

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

        Attachment #72652 -
        Flags: approval+

    
    

    
  
checked in
Status: ASSIGNED → RESOLVED
Closed: 23 years ago → 22 years ago
Resolution: --- → FIXED
Whiteboard: EDITORBASE QAHP, FIX IN HAND, reviewed → EDITORBASE QAHP

    
    

    
  
Verified on Win XP using build 03-07.
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: