Closed
Bug 1277004
Opened 8 years ago
Closed 8 years ago
font color from installed theme used inappropriately in the addressbook
Categories
(Thunderbird :: Theme, defect)
Thunderbird
Theme
Tracking
(thunderbird46 wontfix, thunderbird47 wontfix, thunderbird48 fixed, thunderbird49 fixed, thunderbird_esr4549+ fixed)
RESOLVED
FIXED
Thunderbird 49.0
People
(Reporter: aceman, Assigned: Paenglab)
Details
Attachments
(2 files)
169.77 KB,
image/png
|
Details | |
3.27 KB,
patch
|
aceman
:
review+
jorgk-bmo
:
approval-comm-aurora+
rkent
:
approval-comm-esr45+
|
Details | Diff | Splinter Review |
The font color from installed theme is used in the Addressbook when displaying an LDAP directory, while no search has been done yet. So the message says you need to search and the message is in theme color, but the background is not from the theme so the colors mismatch. See attachment.
Comment on attachment 8758388 [details] [diff] [review] Bug1277004.patch Review of attachment 8758388 [details] [diff] [review]: ----------------------------------------------------------------- Nice, thanks.
Attachment #8758388 -
Flags: review?(acelists) → review+
Assignee | ||
Comment 3•8 years ago
|
||
http://hg.mozilla.org/comm-central/rev/d4c9beeca8ed
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 49.0
Assignee | ||
Comment 4•8 years ago
|
||
Comment on attachment 8758388 [details] [diff] [review] Bug1277004.patch [Approval Request Comment] User impact if declined: depending on LW-theme not or hard readable LDAP info text Testing completed (on c-c, etc.): on c-c Risk to taking this patch (and alternatives if risky): low
Attachment #8758388 -
Flags: approval-comm-esr45?
Attachment #8758388 -
Flags: approval-comm-beta?
Attachment #8758388 -
Flags: approval-comm-aurora?
Updated•8 years ago
|
Attachment #8758388 -
Flags: approval-comm-aurora? → approval-comm-aurora+
Comment 5•8 years ago
|
||
https://hg.mozilla.org/releases/comm-aurora/rev/1057658a4ce7
status-thunderbird46:
--- → wontfix
status-thunderbird47:
--- → affected
status-thunderbird48:
--- → fixed
status-thunderbird49:
--- → fixed
status-thunderbird_esr45:
--- → affected
tracking-thunderbird_esr45:
--- → ?
Comment 6•8 years ago
|
||
Too late for TB 47 beta now.
Updated•8 years ago
|
Attachment #8758388 -
Flags: approval-comm-beta?
Comment 7•8 years ago
|
||
Comment on attachment 8758388 [details] [diff] [review] Bug1277004.patch http://hg.mozilla.org/releases/comm-esr45/rev/48109c9f5b1e
Attachment #8758388 -
Flags: approval-comm-esr45? → approval-comm-esr45+
Updated•8 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•