Closed
Bug 1277198
Opened 8 years ago
Closed 8 years ago
Remove AudioStream::mInRate/mOutRate
Categories
(Core :: Audio/Video: Playback, defect)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: jwwang, Assigned: jwwang)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
We already have AudioClock::mInRate/mOutRate. We don't want duplicated copies to increase maintenance effort.
|
Assignee | |
Comment 1•8 years ago
|
||
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=402b155ec8c0
|
|
Assignee | |
Comment 2•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/57836/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/57836/
Attachment #8760119 -
Flags: review?(kinetik)
Attachment #8760120 -
Flags: review?(kinetik)
Attachment #8760121 -
Flags: review?(kinetik)
|
|
Assignee | |
Comment 3•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/57838/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/57838/
|
|
Assignee | |
Comment 4•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/57840/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/57840/
|
||
Comment 5•8 years ago
|
||
Comment on attachment 8760119 [details] Bug 1277198. Part 1 - add AudioClock::GetInputRate/GetOutputRate. . https://reviewboard.mozilla.org/r/57836/#review54670
Attachment #8760119 -
Flags: review?(kinetik) → review+
|
|
||
Comment 6•8 years ago
|
||
Comment on attachment 8760120 [details] Bug 1277198. Part 2 - fix OpenDumpFile(). . https://reviewboard.mozilla.org/r/57838/#review54672
Attachment #8760120 -
Flags: review?(kinetik) → review+
|
|
||
Comment 7•8 years ago
|
||
Comment on attachment 8760121 [details] Bug 1277198. Part 3 - remove AudioStream::mInRate/mOutRate. . https://reviewboard.mozilla.org/r/57840/#review54674
Attachment #8760121 -
Flags: review?(kinetik) → review+
|
|
Assignee | |
Comment 8•8 years ago
|
||
Thanks for the review!
Pushed by jwwang@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/407310ae3088 Part 1 - add AudioClock::GetInputRate/GetOutputRate. r=kinetik. https://hg.mozilla.org/integration/mozilla-inbound/rev/31d28c8d3284 Part 2 - fix OpenDumpFile(). r=kinetik. https://hg.mozilla.org/integration/mozilla-inbound/rev/58b8b9310520 Part 3 - remove AudioStream::mInRate/mOutRate. r=kinetik.
|
||
Comment 10•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/407310ae3088 https://hg.mozilla.org/mozilla-central/rev/31d28c8d3284 https://hg.mozilla.org/mozilla-central/rev/58b8b9310520
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•