127724 - Active Accessibility: nsIAccessible's accDoAction does not work for Html Check Box Node

Status: VERIFIED FIXED

(Core :: Disability Access APIs, defect, P2)

Description

[dsirnapalli]

-- I wrote onClick event on checkbox. When we call accDoAction on Html Check 
box node it does check the checkbox but the event is not fired. 
<input type="checkbox" name="sex" onClick="nodeChecked();"> Above 30
i put some alert statements in nodeChecked() function. they dont get fired when 
the click happens through accDoAction.
i attached a simple test case.run the test case from mozilla or mozinspect. be 
sure to insert the following line in prefs.js
user_pref("signed.applets.codebase_principal_support", true);

Comment 1

[dsirnapalli]

Attachment: Simple test case to reproduce the bug.

Comment 2

[Jaime Rodriguez, Jr.]

nsbeta1+ per ADT/Embed triage.

Comment 3

[Kyle Yuan]

Attachment: patch

use Click method instead of SetChecked to do the default action in
AccDoAction function.

Kyle

Comment 4

[Aaron Leventhal]

Comment on attachment 72559 [details] [diff] [review]
patch

Very good, thank you.
Please remove the old lines, instead of just // commenting them out. 

If you comment lines out, always make sure you also say why they are commented
out. Engineers reading the code in the future may not understand why they have
// in front of them.

Please submit a new patch with the commented lines.

Also, when you attach the patch, be sure to check the checkbox marked "patch"

Comment 5

[Kyle Yuan]

Attachment: new patch

this is a new patch which commented lines are removed.

Comment 6

[Aaron Leventhal]

Comment on attachment 72710 [details] [diff] [review]
new patch

r=aaronl

Comment 7

[Kyle Yuan]

Attachment: new patch (v3)

hi, Aaron, I found that there are some potential errors in 
nsHTMLRadioButtonAccessible::AccDoAction and 
nsHTMLButtonAccessible::AccDoAction which does not check the
element pointer carefully. 
So I re-submited the patch.

Comment 8

[Aaron Leventhal]

Comment on attachment 72718 [details] [diff] [review]
new patch (v3)

Thanks! r=aaronl

Comment 9

[Aaron Leventhal]

Comment on attachment 72710 [details] [diff] [review]
new patch

Marking obsolete. Whenever you attach a new patch, you should mark the old one
obsolete with the checkbox in that page.

Comment 10

[Kyle Yuan]

Yes, I wanted to do that, but the system told me that I haven't
the enough privilege.

Comment 11

[Simon Fraser [no longer active]]

Comment on attachment 72718 [details] [diff] [review]
new patch (v3)

sr=sfraser

Comment 12

[Asa Dotzler [:asa]]

Comment on attachment 72718 [details] [diff] [review]
new patch (v3)

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 13

[Kyle Yuan]

fixed. need to be checkined.

Comment 14

[John Gaunt (redfive)]

I believe Aaron already checked this in when he checked in your other bug ( bug
57263 ). 

In the future, leave the bug unresloved until it gets checked in. In other
words, if the fix is not in the tree ( checked in ) then the bug really isn't
fixed. In this case, I'm pretty sure Aaron checked this in, so I won't reopen 
the bug.

Comment 15

[Aaron Leventhal]

This was in fact checked in.
Sorry for not marking it earlier.

Comment 16

[dsirnapalli]

-- Verified the fix on yesterday's trunk build. 
Works fine. Marking the bug as verified.

Comment 17

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1527381