1277289 - Add an API to obtain all permissions for a specific site from SitePermissions.jsm

Status: RESOLVED FIXED

(Firefox :: General, defect, P1)

Description

[Johann Hofmann [:johannh]]

Quoting Paolo from Bug 1206245:

> If I remember correctly the discussions that led to this and other similar
> API bugs to be filed, we'd like to see a more structured approach to
> SitePermissions.jsm where the data model is more similar to the front-end
> model needed by the control center. One step in that direction could be to
> create a stateFromUri(uri) function that returns an object like this:
> 
> {
>   hasAnyGrantedPermission: true,
>   customizedPermissions: [
>     {
>       id: "...",
>       label: "...",
>       stateLabel: "...",
>     },
>     {
>       id: "...",
>       label: "...",
>       stateLabel: "...",
>       blocked: true,
>     },
>   ],
> }
> 
> And customizedPermissions would be an ordered list. This way, we could have
> simple non-ui regression tests to check that the model works, and we can
> keep the front-end code simpler, just dealing with rendering the controls
> and handling commands.

Comment 1

[Johann Hofmann [:johannh]]

Attachment: MozReview Request: Bug 1277289 - Add a function to obtain all permissions by uri in SitePermissions.jsm. r=paolo

Review commit: https://reviewboard.mozilla.org/r/57196/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/57196/

Comment 2

[Johann Hofmann [:johannh]]

Comment on attachment 8759132 [details]
MozReview Request: Bug 1277289 - Add a function to obtain all permissions by uri in SitePermissions.jsm. r=paolo

Looking at this patch we're actually increasing the code size but I think it still makes sense to put the moving parts into that function so that it can be verified to work independently of the UI.

Paolo, what do you think? I hope that this does what you were suggesting :)

Comment 3

[:Paolo Amadini]

Comment on attachment 8759132 [details]
MozReview Request: Bug 1277289 - Add a function to obtain all permissions by uri in SitePermissions.jsm. r=paolo

Looks just like what we need here. Thanks!

>  // check that it returns an empty array on an invalid uri
>  let wrongURI = Services.io.newURI("file://example.js", null, null)

nit: I was confused for a bit by the reference to "invalid uri" because what is indicated here as "file://example.js" should be properly expressed as "file:///example.js". You should fix the URI and clarify the comment to indicate that we're testing an URI that doesn't support viewing permissions in the user interface.

Comment 4

[:Paolo Amadini]

Also, if I remember correctly it's fine to test English strings, I've seen similar tests around. I don't think we need to annotate the test in any way.

Comment 5

[Johann Hofmann [:johannh]]

Comment on attachment 8759132 [details]
MozReview Request: Bug 1277289 - Add a function to obtain all permissions by uri in SitePermissions.jsm. r=paolo

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/57196/diff/1-2/

Comment 6

[Johann Hofmann [:johannh]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7243b669ccae

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/86dca8a132b5
Add a function to obtain all permissions by uri in SitePermissions.jsm. r=paolo

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/86dca8a132b5