1277389 - 'assert dateTime[0] < yearLimit, 'Something is wrong with this code' in build_scheduler logs

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Nick Thomas [:nthomas] (UTC+12)]

Getting these every few minutes on build_scheduler, going back to at least April 4th. The full traceback is:

2016-06-01 13:49:47-0700 [-] Unhandled Error
        Traceback (most recent call last):
          File "/tools/python27/lib/python2.7/threading.py", line 524, in __bootstrap
            self.__bootstrap_inner()
          File "/tools/python27/lib/python2.7/threading.py", line 551, in __bootstrap_inner
            self.run()
          File "/tools/python27/lib/python2.7/threading.py", line 504, in run
            self.__target(*self.__args, **self.__kwargs)
        --- <exception caught here> ---
          File "/builds/buildbot/build_scheduler/lib/python2.7/site-packages/twisted/python/threadpool.py", line 207, in _worker
            result = context.call(ctx, function, *args, **kwargs)
          File "/builds/buildbot/build_scheduler/lib/python2.7/site-packages/twisted/python/context.py", line 59, in callWithContext
            return self.currentContext().callWithContext(ctx, func, *args, **kw)
          File "/builds/buildbot/build_scheduler/lib/python2.7/site-packages/twisted/python/context.py", line 37, in callWithContext
            return func(*args,**kw)
          File "/builds/buildbot/build_scheduler/lib/python2.7/site-packages/twisted/enterprise/adbapi.py", line 429, in _runInteraction
            result = interaction(trans, *args, **kw)
          File "/builds/buildbot/build_scheduler/lib/python2.7/site-packages/buildbot-0.8.2_hg_8b87b4974e3c_production_0.8-py2.7.egg/buildbot/schedulers/time
d.py", line 243, in _check_timer
            next = self._calculateNextRunTimeFrom(last_build)
          File "/builds/buildbot/build_scheduler/lib/python2.7/site-packages/buildbot-0.8.2_hg_8b87b4974e3c_production_0.8-py2.7.egg/buildbot/schedulers/time
d.py", line 338, in _calculateNextRunTimeFrom
            assert dateTime[0] < yearLimit, 'Something is wrong with this code'
        exceptions.AssertionError: Something is wrong with this code

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

Looks like a malformed range for when periodic builds should run on ash:
  'periodic_start_hours': range(9, 0, 12),
at http://hg.mozilla.org/build/buildbot-configs/file/63ab033a8991/mozilla/project_branches.py#l34

RyanVM - any idea what you were intending there ? Twice a day, at 9am and 9pm perhaps.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Sounds about right. Sorry for the noise.

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: [buildbot-configs] PGO at 9am and 9pm, if the repo has changed

Comment 4

[Jordan Lund (:jlund)]

Comment on attachment 8759023 [details] [diff] [review]
[buildbot-configs] PGO at 9am and 9pm, if the repo has changed

Review of attachment 8759023 [details] [diff] [review]:
-----------------------------------------------------------------

nice find

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8759023 [details] [diff] [review]
[buildbot-configs] PGO at 9am and 9pm, if the repo has changed

https://hg.mozilla.org/build/buildbot-configs/rev/51c2e105e9de

Comment 6

[Release Engineering SlaveAPI Service]

In production: https://hg.mozilla.org/build/buildbot-configs/rev/51c2e105e9de

Comment 7

[Nick Thomas [:nthomas] (UTC+12)]

Master logs have no more tracebacks. \o/