1277548 - Double slash in view photo URL (eg https://phonebook.mozilla.org//pic.php?mail=...)

Status: RESOLVED FIXED

(Webtools Graveyard :: Phonebook, defect)

Description

[Ed Morley [:emorley]]

Not exactly urgent but filing since I noticed it.

When on the view contact page, eg:
https://phonebook.mozilla.org/#search/[e-mail]

The photo's link target (and image src URL) is of form:
https://phonebook.mozilla.org//pic.php?mail=[e-mail]

ie contains a double slash.

The URL is defined here:
https://github.com/mozilla/phonebook/blob/a1349904d144321680ee1c47c43c910a1da0cd8d/config.php#L223

   $entry["picture"] = BASEPATH ."pic.php?mail=". $m[1];

It looks like this is the only time BASEPATH is used. BASEPATH itself is defined here:

https://github.com/mozilla/phonebook/blob/a1349904d144321680ee1c47c43c910a1da0cd8d/constants.php#L43

    define("BASEPATH", $protocol . $_SERVER["HTTP_HOST"] . dirname($_SERVER["REQUEST_URI"]) .'/');

I'm not sure whether it's ok to just drop the slash being appended there, or whether it may break eg the local testing case.

Comment 1

[:Atoll]

https://github.com/mozilla/phonebook/pull/43 drops BASEPATH entirely, going with href="pic.php" since that's what we do everywhere else in Phonebook.

Comment 2

[Ed Morley [:emorley]]

Many thanks :-)

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/phonebook

https://github.com/mozilla/phonebook/commit/e48face610882e46e2a3fbc4ffb193d3203a4834
Merge pull request #43 from floatingatoll/bug1277548

Use relative HREF to pic.php, remove BASEPATH. [#1277548]

Comment 4

[:Atoll]

Fix deployed to production, CHG0010767.