Closed
Bug 1277999
Opened 8 years ago
Closed 8 years ago
Regression: History smartfolder icons are too big
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox48 affected, firefox49 affected, fennec48+, firefox50 verified)
RESOLVED
FIXED
Firefox 50
People
(Reporter: liuche, Assigned: liuche)
References
Details
Attachments
(1 file)
For some reason, the icons for smartfolders have embiggened themselves. I checked the dimensions used (favicon_bg) but it doesn't seem to have changed, so something else is going on.
Updated•8 years ago
|
tracking-fennec: --- → ?
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/58372/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/58372/
Attachment #8760997 -
Flags: review?(jonalmeida942)
Assignee | ||
Comment 2•8 years ago
|
||
This icon doesn't need to be scaled or centered - it was just missing some padding in order to match the dimens in the mocks.
status-firefox48:
--- → affected
Updated•8 years ago
|
Attachment #8760997 -
Flags: review?(jonalmeida942) → review+
Comment 3•8 years ago
|
||
Comment on attachment 8760997 [details] Bug 1277999 - Regression: History smartfolder icons are too big. https://reviewboard.mozilla.org/r/58372/#review55230
Pushed by cliu@mozilla.com: https://hg.mozilla.org/integration/fx-team/rev/6b9019f91562 Regression: History smartfolder icons are too big. r=jonalmeida
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → liuche
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/6b9019f91562
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Assignee | ||
Comment 6•8 years ago
|
||
Comment on attachment 8760997 [details] Bug 1277999 - Regression: History smartfolder icons are too big. Approval Request Comment [Feature/regressing bug #]: bug 1261527 scaled icon [User impact if declined]: smartfolder icon for Synced devices will be too big [Describe test coverage new/current, TreeHerder]: local testing [Risks and why]: very low, adds padding, removes scaling in xml [String/UUID change made/needed]: none
Attachment #8760997 -
Flags: approval-mozilla-beta?
Attachment #8760997 -
Flags: approval-mozilla-aurora?
tracking-fennec: ? → 48+
Assignee | ||
Comment 7•8 years ago
|
||
Comment on attachment 8760997 [details] Bug 1277999 - Regression: History smartfolder icons are too big. It looks like this changes how icons are displayed on hdpi devices, so let's not uplift this patch.
Attachment #8760997 -
Flags: approval-mozilla-beta?
Attachment #8760997 -
Flags: approval-mozilla-aurora?
Comment 8•8 years ago
|
||
Verified as fixed in build 50.0a1 (2016-06-16); Device: - Asus ZenPad 8 (Android 5.0.2); - Motorola Razr (Android 4.4.4); - Nexus 5 (Android 6.0.1).
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•