Closed
Bug 1278306
Opened 8 years ago
Closed 8 years ago
Remove all uses of 'content.location = ' in the webconsole tests
Categories
(DevTools :: Console, defect, P1)
DevTools
Console
Tracking
(e10s+, firefox48 fixed, firefox49 fixed, firefox50 fixed)
RESOLVED
FIXED
Firefox 50
People
(Reporter: bgrins, Assigned: moby)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
15.63 KB,
patch
|
bgrins
:
review+
|
Details | Diff | Splinter Review |
Let's just take care of a bunch of these CPOWs in one patch. We shouldn't be using content.location = foo anymore, and should instead use BrowserTestUtils.loadURI(gBrowser.selectedBrowser, foo);
Reporter | ||
Comment 1•8 years ago
|
||
Moby, can you take a look at this one for the webconsole test directory?
Flags: needinfo?(mvonbriesen)
Priority: -- → P1
Version: 46 Branch → Trunk
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → mvonbriesen
Flags: needinfo?(mvonbriesen)
Assignee | ||
Comment 2•8 years ago
|
||
(In reply to Brian Grinstead [:bgrins] from comment #1) > Moby, can you take a look at this one for the webconsole test directory? Sure
Assignee | ||
Comment 3•8 years ago
|
||
Attachment #8760428 -
Flags: review?(bgrinstead)
Reporter | ||
Comment 4•8 years ago
|
||
Comment on attachment 8760428 [details] [diff] [review] remove-content-location.patch Review of attachment 8760428 [details] [diff] [review]: ----------------------------------------------------------------- Looks good - this should prevent a bunch of intermittents on e10s. Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=bb37e25bb2c3
Attachment #8760428 -
Flags: review?(bgrinstead) → review+
Updated•8 years ago
|
tracking-e10s:
--- → ?
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Updated•8 years ago
|
Blocks: e10s-tests
Reporter | ||
Updated•8 years ago
|
Status: NEW → ASSIGNED
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/fx-team/rev/54354d5ade58 Remove all uses of 'content.location = ' in the webconsole tests; r=bgrins
Keywords: checkin-needed
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/54354d5ade58
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Comment 7•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/bc5cb981f4b8
status-firefox49:
--- → fixed
Comment 8•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/e07acf9e5bd8
status-firefox48:
--- → fixed
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•