1278752 - Two Coverity fixes for the JIT

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Nicholas Nethercote [inactive]]

Two Coverity fixes coming up.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: (part 1) - Add a missing null check in PropertyTypeIncludes

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: (part 2) - Make explicit the ignoring of a hasStableClassAndProto() return value

bhackett, I *think* this call is just for its side-effects and the return value
doesn't matter, but confirmation would be helpful. Thank you.

Comment 3

[Brian Hackett [Laid off!]]

Comment on attachment 8761061 [details] [diff] [review]
(part 2) - Make explicit the ignoring of a hasStableClassAndProto() return value

Review of attachment 8761061 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, the TemporaryTypeSet constructor will internally check for groups with unknown properties (which groups with unstable class/proto will have), so the rval isn't needed here.

Comment 4

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d1e5d75a2e9d6f46a48bc66c243dcfeb2cd40788
Bug 1278752 (part 1) - Add a missing null check in PropertyTypeIncludes. r=bhackett.

https://hg.mozilla.org/integration/mozilla-inbound/rev/87f4fe4848c26efe073ed77313aac00ffd437060
Bug 1278752 (part 2) - Make explicit the ignoring of a hasStableClassAndProto() return value. r=bhackett.

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d1e5d75a2e9d
https://hg.mozilla.org/mozilla-central/rev/87f4fe4848c2