Closed Bug 1278851 Opened 8 years ago Closed 8 years ago

Enable service worker notifications everywhere except for non-release B2G

Categories

(Core :: DOM: Push Subscriptions, defect)

Product:
Core
Component:
DOM: Push Subscriptions
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla50
Tracking Flags:
Tracking Status
firefox47 --- unaffected
firefox48 + fixed
firefox49 blocking fixed
firefox50 --- fixed

People

(Reporter: lina, Assigned: lina)

References

Details

(Whiteboard: btpp-active)

Attachments

(1 file)

notifsEverywhere.patch
4.53 KB, patch
lina
: review+
Sylvestre
: approval-mozilla-aurora+
Sylvestre
: approval-mozilla-beta+
Details | Diff | Splinter Review 
Already r+'ed by baku in bug 1278435, comment 10. Moving the patch out into a separate bug because this one needs to go through the uplift process and land everywhere.

Requesting tracking for 48 and 49 because we want to ship push in Android 48. Without this, a service worker could receive pushes, but not show any notifications.
Attachment #8761213 - Flags: review+
Pushed by kcambridge@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5a5df0f767ed
Enable service worker notifications everywhere except for non-release B2G. r=baku
Comment on attachment 8761213 [details] [diff] [review]
notifsEverywhere.patch

Approval Request Comment
[Feature/regressing bug #]: Android push notifications.
[User impact if declined]: Service workers won't be able to show notifications to the user on Android release builds.
[Describe test coverage new/current, TreeHerder]: Covered by existing tests.
[Risks and why]: Low risk, since service worker notifications were already available in non-release builds.
[String/UUID change made/needed]: None.
Attachment #8761213 - Flags: approval-mozilla-beta?
Attachment #8761213 - Flags: approval-mozilla-aurora?
Whiteboard: btpp-active
https://hg.mozilla.org/mozilla-central/rev/5a5df0f767ed
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox50: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Comment on attachment 8761213 [details] [diff] [review]
notifsEverywhere.patch

OK, let's ship that!
Thanks
Should be in 48 beta 2
Attachment #8761213 - Flags: approval-mozilla-beta?
Attachment #8761213 - Flags: approval-mozilla-beta+
Attachment #8761213 - Flags: approval-mozilla-aurora?
Attachment #8761213 - Flags: approval-mozilla-aurora+
Thanks, Sylvestre!
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: