Closed
Bug 1278959
Opened 8 years ago
Closed 8 years ago
MOZ_ANDROID_PACKAGE_INSTALL_BOUNCER can't be set via mozconfig
Categories
(Firefox Build System :: Android Studio and Gradle Integration, defect)
Firefox Build System
Android Studio and Gradle Integration
Tracking
(firefox50 fixed)
RESOLVED
FIXED
mozilla50
Tracking | Status | |
---|---|---|
firefox50 | --- | fixed |
People
(Reporter: mkaply, Unassigned)
Details
Attachments
(1 file)
Currently the setting for building the bouncer is in mobile/android/confvars.sh and looks like this: MOZ_ANDROID_PACKAGE_INSTALL_BOUNCER=1 If you change it to 0: MOZ_ANDROID_PACKAGE_INSTALL_BOUNCER=0 we still build the bouncer. Looking at the source code, I see code like this: http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/installer/upload-files-APK.mk#47 ifdef MOZ_ANDROID_PACKAGE_INSTALL_BOUNCER INNER_INSTALL_BOUNCER_PACKAGE=true 1. The bouncer variable should properly work when set to 0. 2. We should actually be setting this variable in mozconfig or some other place versus requiring a change to confvars.sh and a rebuild.
Reporter | ||
Comment 1•8 years ago
|
||
Chris: Is this something you can help with? Thanks.
Flags: needinfo?(cmanchester)
Comment 2•8 years ago
|
||
To address turning this off from confvars.sh, I think you need to have MOZ_ANDROID_PACKAGE_INSTALL_BOUNCER= so the makefile doesn't see '0' as a truthy value. We can move this to an environment settable thing that defaults to true by moving it to and appropriate definition in mobile/android/moz.configure, but note that a re-build will still be needed when updating the value. Let me know if this seems advantageous, I can write up a patch (the way we handle MOZ_ANDROID_APZ in that file is similar to what we would do here).
Flags: needinfo?(cmanchester)
Reporter | ||
Comment 3•8 years ago
|
||
> We can move this to an environment settable thing that defaults to true by moving it to and appropriate definition in mobile/android/moz.configure, but note that a re-build will still be needed when updating the value. Let me know if this seems advantageous, I can write up a patch (the way we handle MOZ_ANDROID_APZ in that file is similar to what we would do here).
Requiring a rebuild is fine, I just don't want to have to modify confvars.sh to change the value.
Thanks!
Comment 4•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/58594/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/58594/
Attachment #8761376 -
Flags: review?(mh+mozilla)
Comment 5•8 years ago
|
||
Comment on attachment 8761376 [details] Bug 1278959 - Move MOZ_ANDROID_PACKAGE_INSTALL_BOUNCER to Python configure and make is settable by mozconfig. https://reviewboard.mozilla.org/r/58594/#review55602
Attachment #8761376 -
Flags: review?(mh+mozilla) → review+
Pushed by cmanchester@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/6fb515b4a1ba Move MOZ_ANDROID_PACKAGE_INSTALL_BOUNCER to Python configure and make it settable by mozconfig. r=glandium
Comment 7•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/6fb515b4a1ba
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Updated•5 years ago
|
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 50 → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•