Closed
Bug 1279006
Opened 8 years ago
Closed 8 years ago
Fix another improbable race and clean up node destruction tests
Categories
(DevTools Graveyard :: Web Audio Editor, defect)
DevTools Graveyard
Web Audio Editor
Tracking
(firefox48 fixed, firefox49 fixed, firefox50 fixed)
RESOLVED
FIXED
Firefox 50
People
(Reporter: efaust, Assigned: efaust)
References
Details
Attachments
(1 file)
4.74 KB,
patch
|
bgrins
:
review+
|
Details | Diff | Splinter Review |
After bug 1115779, I noticed that there was another GC-related race in the node destruction tests. Since then odes are created as garbage, a GC event (though very unlikely) could clean them up before we expected them to be collected, resulting in a different intermittent hang. This should clean up the issue. We can also move the rmoval listeners to a more logical place, since they are not racing singe the beginning anymore.
Attachment #8761345 -
Flags: review?(bgrinstead)
Comment 1•8 years ago
|
||
Comment on attachment 8761345 [details] [diff] [review] Fix Review of attachment 8761345 [details] [diff] [review]: ----------------------------------------------------------------- Better in so many ways, thanks! ::: devtools/client/webaudioeditor/test/doc_destroy-nodes.html @@ +12,5 @@ > > <script type="text/javascript;version=1.8"> > "use strict"; > + // Keep the nodes we want to GC alive until we are ready for them to > + // be collected. We will zero this reference by force from the devtools Nit: 'from the devtools side' -> 'in forceNodeCollection'
Attachment #8761345 -
Flags: review?(bgrinstead) → review+
Updated•8 years ago
|
Comment 2•8 years ago
|
||
Comment on attachment 8761345 [details] [diff] [review] Fix Review of attachment 8761345 [details] [diff] [review]: ----------------------------------------------------------------- Also, please give this a sensible commit message before landing
Assignee | ||
Updated•8 years ago
|
Summary: Fix another improbably race in node destruction tests → Fix another improbable race and clean up node destruction tests
Pushed by efaustbmo@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/df61facc5659 Clean up webaudioeditor node destruction tests, and fix another race condition. (r=bgrins)
Comment 4•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/df61facc5659
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Comment 5•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/24c398084956
status-firefox49:
--- → fixed
Comment 6•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/758bf5a6607b
status-firefox48:
--- → fixed
Updated•6 years ago
|
Product: Firefox → DevTools
Updated•5 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•