1279198 - Inconsistency between "Dismiss" button name and block action

Status: RESOLVED FIXED

(Firefox Graveyard :: Activity Streams: General, defect)

Description

[Vlad Bacia-Mociran [:VladB]]

Attachment: dismiss vs block.jpg

[Affected versions]:
- Firefox 45.0 and up
- Activity Stream 1.0.19-dev

[Affected Platforms]:
- All Windows
- All Linux
- All Mac OS

[Prerequisites]:
- Latest Activity Stream add-on version (1.0.19) was previously installed on a profile.
- Have enough history so that the "Top Sites", "Highlights", "History" areas are populated with visited websites.

[Steps to reproduce]:
1. Open the browser with the profile from prerequisites.
2. Open a New Tab so the Activity Stream New Tab page is displayed.
3. Move the mouse cursor over a visited item.
4. Click on "..." button.
5. Observe the "Dismiss" option.
6. Click on "Dismiss" button.
7. Click on "Setting" button from Activity Stream New Tab page.
8. Observe "Reset Block List" option.

[Expected result]:
- Instead of "Dismiss" button there should be an option related to "Block", so the user knows exactly what that option does.

[Actual result]:
- In the new context menu the blocking option is called "Dismiss". This naming is not intuitive nor consistent with the "Reset Block List" option from Settings menu in the Activity Stream New Tab Page.

[Notes]:
- The naming for the block option should reflect exactly what the option will do. Examples of naming: "Add to Block List", "Block this page", "Block from Activity Stream".
- At first sight, I've associated the "Dismiss" option with the close context menu action. From my point of view, a user that will use Activity Stream for the first time will have difficulties in associating the "Dismiss" button with the block action and Reset Block List.

Comment 1

[Paul Oiegas [:poiegas], PM for (Ecosystem QA, Services QA, WebCompat QA, Hubs QA teams)]

Filed in GitHub as https://github.com/mozilla/activity-stream/issues/813

Comment 2

[Vlad Bacia-Mociran [:VladB]]

Check after https://github.com/mozilla/activity-stream/issues/870 is implemented.

Comment 3

[Kate Hudson :k88hudson]

Fixed in https://github.com/mozilla/activity-stream/pull/906