Closed
Bug 1279215
Opened 8 years ago
Closed 8 years ago
Move Tabs component to shared/components
Categories
(DevTools :: Framework, defect, P1)
DevTools
Framework
Tracking
(firefox50 fixed)
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: Honza, Assigned: Honza)
References
Details
(Whiteboard: [devtools-html])
Attachments
(1 file, 1 obsolete file)
|
6.24 KB,
patch
|
Honza
:
review+
|
Details | Diff | Splinter Review |
Tabs component in jsonview/components/reps should be moved to shared/components/tabs Honza
|
Assignee | |
Updated•8 years ago
|
|
||
Updated•8 years ago
|
Blocks: devtools-html-2
Whiteboard: [devtools-html] → [devtools-html] [triage]
|
|
||
Updated•8 years ago
|
Status: NEW → ASSIGNED
Iteration: --- → 50.1
Flags: qe-verify-
Priority: -- → P1
Whiteboard: [devtools-html] [triage] → [devtools-html]
|
|
Assignee | |
Comment 1•8 years ago
|
||
@Patrick, I am moving the Tabs component from jsonview to shared components directory (it's related to the bug 1259819). Honza
Attachment #8761573 -
Flags: review?(pbrosset)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8761573 [details] [diff] [review] bug1279215.patch Review of attachment 8761573 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #8761573 -
Flags: review?(pbrosset) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
Thanks for quick review. Yet one try push to make sure all's good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=95433f1ca851 Honza
|
|
Assignee | |
Comment 4•8 years ago
|
||
One more module path fixed. New try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b9b109c3d768 Honza
Attachment #8761584 -
Flags: review+
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8761573 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/fx-team/rev/29e262587b6b Move Tabs component to shared/components; r=pbro
Keywords: checkin-needed
|
||
Comment 6•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/29e262587b6b
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•