1279985 - Description for SSL_CIPHER_SUITE_* out of date

Status: RESOLVED FIXED

(Core :: Security: PSM, defect, P5)

Description

[Chris H-C :chutten]

The SSL_CIPHER_SUITE_* descriptions in Histograms.json points at nsNSSCallbacks::HandleCallbacks. It should probably point instead at nsNSSCallbacks::AccumulateCipherSuite[0].

[0]: https://dxr.mozilla.org/mozilla-central/rev/b6f7d0eb61b1878d3d906bd231edf225463ece3f/security/manager/ssl/nsNSSCallbacks.cpp#1019

Comment 1

[Federico Padua [:fedepad]]

(In reply to Chris H-C :chutten from comment #0)
> The SSL_CIPHER_SUITE_* descriptions in Histograms.json points at
> nsNSSCallbacks::HandleCallbacks. It should probably point instead at
> nsNSSCallbacks::AccumulateCipherSuite[0].
> 
> [0]:
> https://dxr.mozilla.org/mozilla-central/rev/
> b6f7d0eb61b1878d3d906bd231edf225463ece3f/security/manager/ssl/nsNSSCallbacks.
> cpp#1019

Those probes [0] are used in the call to nsNSSCallbacks::AccumulateCipherSuite inside nsNSSCallbacks::HandshakeCallback. And yes, the key exchanges seem to live in nsNSSCallbacks::AccumulateCipherSuite.

If this is still due, should I go ahead? 
Is changing the function name (HandshakeCallback) in Histograms.json the only change to be made?

If yes, I'm gonna prepare a patch for it soon. And who I should put as reviewer?

Thanks!


[0]: https://dxr.mozilla.org/mozilla-central/rev/b6f7d0eb61b1878d3d906bd231edf225463ece3f/security/manager/ssl/nsNSSCallbacks.cpp#1079,1115-1118

Comment 2

[Federico Padua [:fedepad]]

Attachment: Bug 1279985 - Description for SSL_CIPHER_SUITE_* out of date;

This patch updates the description for the probes SSL_CIPHER_SUITE_FULL and
SSL_CIPHER_SUITE_RESUMED found in Histograms.json to point to
AccumulateCipherSuite which contains the key exchanges instead of the previous
HandshakeCallback.

Review commit: https://reviewboard.mozilla.org/r/123636/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/123636/

Comment 3

[Chris H-C :chutten]

Comment on attachment 8851281 [details]
Bug 1279985 - Description for SSL_CIPHER_SUITE_* out of date;

https://reviewboard.mozilla.org/r/123636/#review126316

This is exactly what's needed, and why this is a good first bug. Thanks! I'll have this pushed.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9a6eebeed904
Description for SSL_CIPHER_SUITE_* out of date; r=chutten

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9a6eebeed904