1280086 - Child process shouldn't send events to parent if a11y isn't enabled in parent

Status: NEW

(Core :: Disability Access APIs, defect, P3)

Description

[Lorien Hu (:lsocks)]

Child process will try to send IPC messages to parent when parent process doesn't have a11y enabled but child does (e.g. marionette-e10s tests)

Comment 1

[Lorien Hu (:lsocks)]

Attachment: check if a11y is enabled in parent first before sending events

Comment 2

[Trevor Saunders (:tbsaunde)]

Comment on attachment 8762717 [details] [diff] [review]
check if a11y is enabled in parent first before sending events

r=me with the first comment fixed.

> Accessible::HandleAccEvent(AccEvent* aEvent)
> {
>   NS_ENSURE_ARG_POINTER(aEvent);
> 
>-  if (IPCAccessibilityActive() && Document()) {
>+  if (IPCAccessibilityActive() && Document() && GetAccService()->IsEnabledInChrome()) {

you missed the IPCAccessibilityActive() check in DocManager.cpp which would have the effect of not creating any DocAccessibleParents (the NotificationController change prevents sub document ones).

>+
>+  virtual void SetEnabledInChrome() = 0;

could use a comment.  Also yuk this interface should be merged with nsAccessibilityService itself, but that requires either a static cast or fixing how the service is started which I don't think needs to be done now.