1280198 - Convert zipwriter/test/unit/test_asyncadd.js to use channel.open2()

Status: RESOLVED FIXED

(Core :: DOM: Security, defect)

Comment 1

[Christoph Kerschbaumer [:ckerschb]]

Attachment: bug_1280198_convert_test_asyncadd_open2.patch

Kris, you have been touching that test and you are familiar with our conversion from using open() to using open2(). Not changing any functionality within that test - are you willing to sign off on that change?

Comment 2

[Kris Maglione [:kmag]]

Comment on attachment 8762866 [details] [diff] [review]
bug_1280198_convert_test_asyncadd_open2.patch

Review of attachment 8762866 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me

::: modules/libjar/zipwriter/test/unit/test_asyncadd.js
@@ +3,5 @@
>   * file, You can obtain one at http://mozilla.org/MPL/2.0/.
>   */
>  
>  var Cu = Components.utils;
> +Cu.import("resource://gre/modules/NetUtil.jsm");

The definition of |ioSvc| an also be removed from head_zipwriter.js now.

@@ +79,5 @@
>    stream: function method_stream(entry, source)
>    {
>      zipW.addEntryStream(entry, source.lastModifiedTime * PR_MSEC_PER_SEC,
>                          Ci.nsIZipWriter.COMPRESSION_NONE,
> +                         NetUtil.newChannel({

Nit: The added lines all have an extra leading space.

Comment 3

[Christoph Kerschbaumer [:ckerschb]]

Attachment: bug_1280198_convert_test_asyncadd_open2.patch

Thanks!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cf8d980f3031
Convert zipwriter/test/unit/test_asyncadd.js to use channel.open2() r=kmaglione

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cf8d980f3031