1280295 - remove MOZ_HAVE_REF_QUALIFIERS

Status: RESOLVED FIXED

(Core :: MFBT, defect, P3)

Description

[Nathan Froyd [:froydnj]]

Once we depend on msvc2015, all of our supported compilers support this, so we can get rid of the conditional code.

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: remove-MOZ_HAVE_REF_QUALIFIERS.patch

Now that we require VS2015 (bug 1186064) and gcc >= 4.8.5 (bug 1175546), we can use reference qualifiers.

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8774074 [details] [diff] [review]
remove-MOZ_HAVE_REF_QUALIFIERS.patch

Review of attachment 8774074 [details] [diff] [review]:
-----------------------------------------------------------------

The minimum 4.8.0 requirement (cf. mfbt/Compiler.h) is not the same thing as requiring 4.8.1 for this feature, yes?

Comment 3

[Mike Hommey [:glandium]]

Note the canonical compiler version check is in build/moz.configure/toolchain.configure, not mfbt/Compiler.h.

Comment 4

[Chris Peterson [:cpeterson]]

Oops. Thanks. I was confused by bug 1175546, which bumped the minimum GCC version to 4.8.5 in some files:

https://bugzilla.mozilla.org/show_bug.cgi?id=1175546#c17

https://hg.mozilla.org/mozilla-central/rev/2d59367c985a

Comment 5

[Chris Peterson [:cpeterson]]

Comment on attachment 8774074 [details] [diff] [review]
remove-MOZ_HAVE_REF_QUALIFIERS.patch

Now that we require gcc 4.9 (bug 1322792), we can remove MOZ_HAVE_REF_QUALIFIERS and use reference qualifiers.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/49ee681bcb6c
Remove MOZ_HAVE_REF_QUALIFIERS. r=froydnj

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/49ee681bcb6c