Closed
Bug 1280580
Opened 8 years ago
Closed 8 years ago
Android native fling animation is returning an inverted velocity
Categories
(Firefox for Android Graveyard :: Toolbar, defect, P2)
Tracking
(firefox47 unaffected, firefox48 verified, firefox49 verified, firefox50 verified)
VERIFIED
FIXED
Firefox 50
Tracking | Status | |
---|---|---|
firefox47 | --- | unaffected |
firefox48 | --- | verified |
firefox49 | --- | verified |
firefox50 | --- | verified |
People
(Reporter: rbarker, Assigned: rbarker)
References
Details
(Keywords: regression)
Attachments
(1 file)
1.26 KB,
patch
|
kats
:
review+
gchang
:
approval-mozilla-aurora+
gchang
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
The android native fling animation is returning the velocity inverted. This is causing permanent checkerboarding in some situations.
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8763193 -
Flags: review?(bugmail.mozilla)
Comment 2•8 years ago
|
||
Comment on attachment 8763193 [details] [diff] [review] 0001-Bug-1280580-Android-native-fling-animation-is-returning-an-inverted-velocity-r-16061710-ff50a23.patch Review of attachment 8763193 [details] [diff] [review]: ----------------------------------------------------------------- Check to see if this fixes bug 1280085 too.
Attachment #8763193 -
Flags: review?(bugmail.mozilla) → review+
Updated•8 years ago
|
Assignee: nobody → rbarker
Priority: -- → P2
Pushed by rbarker@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f97c058ecdeb Android native fling animation is returning an inverted velocity r=kats
Updated•8 years ago
|
Updated•8 years ago
|
Keywords: regression
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f97c058ecdeb
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Assignee | ||
Comment 6•8 years ago
|
||
Comment on attachment 8763193 [details] [diff] [review] 0001-Bug-1280580-Android-native-fling-animation-is-returning-an-inverted-velocity-r-16061710-ff50a23.patch Approval Request Comment [Feature/regressing bug #]: End of page bounce animation plays at the wrong end of the page. [User impact if declined]: Application will give incorrect user feedback when end of page is reached. [Describe test coverage new/current, TreeHerder]: None, just manually verified. [Risks and why]: Very low risk. Patch only negates the calculated velocity. [String/UUID change made/needed]: none.
Attachment #8763193 -
Flags: approval-mozilla-beta?
Attachment #8763193 -
Flags: approval-mozilla-aurora?
Assignee | ||
Updated•8 years ago
|
Updated•8 years ago
|
Comment 7•8 years ago
|
||
Comment on attachment 8763193 [details] [diff] [review] 0001-Bug-1280580-Android-native-fling-animation-is-returning-an-inverted-velocity-r-16061710-ff50a23.patch Review of attachment 8763193 [details] [diff] [review]: ----------------------------------------------------------------- Fix a regression. Take it in 48 beta 4 and aurora.
Attachment #8763193 -
Flags: approval-mozilla-beta?
Attachment #8763193 -
Flags: approval-mozilla-beta+
Attachment #8763193 -
Flags: approval-mozilla-aurora?
Attachment #8763193 -
Flags: approval-mozilla-aurora+
Comment 8•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/fb650a44de9e
Comment 9•8 years ago
|
||
has problems uplifting to beta merging gfx/layers/apz/src/AndroidAPZ.cpp warning: conflicts while merging gfx/layers/apz/src/AndroidAPZ.cpp! (edit, then use 'hg resolve --mark') abort: unresolved conflicts, can't continue
Flags: needinfo?(rbarker)
Comment 10•8 years ago
|
||
worked after landing the other patch https://hg.mozilla.org/releases/mozilla-beta/rev/f63502a8a7ea
Flags: needinfo?(rbarker)
Comment 11•8 years ago
|
||
Verified as fixed in build Firefox 48 Beta 6; Device: LG G4 (Android 5.1).
Updated•8 years ago
|
status-firefox47:
--- → unaffected
Version: unspecified → 48 Branch
Comment 12•8 years ago
|
||
Verified as fixed in build Firefox 50.0a1 (2016-07-12); Device: Prestigio Grace X5 (Android 4.4.2).
Comment 13•8 years ago
|
||
Verified as fixed in build Firefox 49.0a2 (2016-07-17); Device: LG G4 (Android 5.1).
Comment 14•8 years ago
|
||
I'm changing the status to verified fixed considering that the bug is verified.
Status: RESOLVED → VERIFIED
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•