1280956 - Use in-tree linter job to flake8 test taskcluster directory

Status: RESOLVED FIXED

(Taskcluster :: General, defect)

Description

[Justin Wood (:Callek)]

Attachment: Flake8 Errors (as of my patch queue)

We should just use the in-tree flake8 job to test taskcluster along with the other directories.

Using the design at http://codeverge.com/mozilla.dev.builds/python-flake8-linter-task-live-on-treeherd/2043294

Comment 1

[Justin Wood (:Callek)]

Attachment: Bug 1280956 - Use in-tree linter job to flake8 test taskcluster directory

Review commit: https://reviewboard.mozilla.org/r/59856/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/59856/

Comment 2

[Justin Wood (:Callek)]

Comment on attachment 8763722 [details]
Bug 1280956 - Use in-tree linter job to flake8 test taskcluster directory

Not sure how to assign a reviewer through mozreview :(

Comment 3

[Justin Wood (:Callek)]

Try run at https://treeherder.mozilla.org/#/jobs?repo=try&revision=144d3b0467dd

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8763722 [details]
Bug 1280956 - Use in-tree linter job to flake8 test taskcluster directory

https://reviewboard.mozilla.org/r/59856/#review56912

I look forward to rebasing over this ;)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a1748bc8704a
Use in-tree linter job to flake8 test taskcluster directory. r=dustin

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a1748bc8704a

Comment 7

[Andrew Halberstadt [:ahal]]

Did you guys mean to add taskcluster/** to the flake8-gecko task here?
https://dxr.mozilla.org/mozilla-central/source/taskcluster/ci/legacy/tasks/branches/base_jobs.yml#736

Keeping in mind the job already runs on **/*.py. The taskcluster line means we run the flake8 job whenever *any* file is changed under taskcluster, even non-python files. I suspect this was an accident, but want to double check.

Comment 8

[Dustin J. Mitchell [:dustin] (he/him)]

Yeah, that should be **.py

Comment 9

[Andrew Halberstadt [:ahal]]

Which is already included on the first line, so it should just be removed.

Comment 10

[Justin Wood (:Callek)]

Agreed, this was a mistake in my side of things...