Closed
Bug 1280985
Opened 8 years ago
Closed 8 years ago
Move presence indicator to the sidebar
Categories
(Hello (Loop) :: Client, defect)
Hello (Loop)
Client
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: fcampo, Assigned: mancas)
References
Details
Attachments
(2 files)
New Sidebar UI
On the new UI, we need to move the presence indicators (bubble with avatar / username initial) to the sidebar, place it next to the media controls.
|
Reporter | |
Updated•8 years ago
|
|
||
Comment 1•8 years ago
|
||
|
Assignee | |
Updated•8 years ago
|
Attachment #8763798 -
Flags: review?(fernando.campo)
Attachment #8763798 -
Flags: review?(edilee)
Attachment #8763798 -
Flags: review?(dmose)
Attachment #8763798 -
Flags: review?(dcritchley)
|
|
Assignee | |
Comment 2•8 years ago
|
||
Ready for review
|
|
Reporter | |
Comment 3•8 years ago
|
||
Comment on attachment 8763798 [details] [review] [loop] mancas:bug1280985 > mozilla:akita looks nice, and thanks for the refactoring too. r+ with an open question, as we may want to use the occasion to make chat bigger and hide avatar/media space completely until presence is detected (not only the controls). I don't see a reason to have that space unused until an avatar is needed (someone else in the room). But of course, this can be done in a different bug too.
Attachment #8763798 -
Flags: review?(fernando.campo)
Attachment #8763798 -
Flags: review?(edilee)
Attachment #8763798 -
Flags: review?(dmose)
Attachment #8763798 -
Flags: review?(dcritchley)
Attachment #8763798 -
Flags: review+
|
|
Assignee | |
Comment 4•8 years ago
|
||
Landed in akita: https://github.com/mozilla/loop/commit/8a1637cfa1ee33f03fca331102214cae1ba21ee7
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•