1281030 - Not compatible error when trying to install Webextension with update_url

Status: RESOLVED INVALID

(WebExtensions :: Untriaged, defect, P1)

Description

[Paul Heil]

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:48.0) Gecko/20100101 Firefox/48.0
Build ID: 20160606200529

Steps to reproduce:

Create extension and add update_url to applications gecko.  (For unlisted extension)
Try to install extension
(Signed status does not affect error)

Related post:  https://discourse.mozilla-community.org/t/webextensions-update-url-in-manifest-json-exception/9102


Actual results:

Error message that extension is not compatible and this console message.

1466450667609	addons.manager	WARN	InstallListener threw exception when calling onNewInstall: TypeError: app is undefined (resource://gre/modules/commonjs/toolkit/loader.js -> resource://testpilot-addon/index.js:536:5) JS Stack trace: [e-mail]:536:5 < [e-mail]:1716:15 < [e-mail]:2976:12 < [e-mail]:5347:5 < [e-mail]:6339:5 < [e-mail]:3858:5 < [e-mail]:254:12 < [e-mail]:1911:9 < [e-mail]:3315:5 < [e-mail]:114:7 < [e-mail]:155:5 < [e-mail]:191:16
1466450667615	addons.manager	WARN	InstallListener threw exception when calling onDownloadStarted: TypeError: app is undefined (resource://gre/modules/commonjs/toolkit/loader.js -> resource://testpilot-addon/index.js:542:5) JS Stack trace: [e-mail]:542:5 < [e-mail]:1716:15 < [e-mail]:2976:12 < [e-mail]:5718:10 < [e-mail]:5362:7 < [e-mail]:6424:5 < [e-mail]:78:7 < [e-mail]:335:5 < [e-mail]:2200:16 < [e-mail]:3394:5 < [e-mail]:110:9 < amManager.prototype.installAddonsFromWebpage/buildNextInstall/<@addonManager.js:152:9 < [e-mail]:179:5 < [e-mail]:1914:11 < this.XPIProvider.getInstallForURL/<@XPIProvider.jsm:3859:7 < makeSafe/<@XPIProvider.jsm:1982:24 < [e-mail]:5350:5 < [e-mail]:6339:5 < [e-mail]:3858:5 < [e-mail]:254:12 < [e-mail]:1911:9 < [e-mail]:3315:5 < [e-mail]:114:7 < [e-mail]:155:5 < [e-mail]:191:16


Expected results:

Add-on should install

Comment 1

[:shell escalante]

andrew swan looked at stack traces and addon manager and test pilot in the mix... more concrete steps to repro helpful and then update bug/potentially hand to aswan

Comment 2

[Bob Silverberg [:bsilverberg]]

I have been unable to reproduce this error in 48, 49 or 50. I have attached a simple web extension that does specify an `update_url` which I used for testing. Could you provide us with a web extension that reproduces the problem for you?

Comment 3

[Bob Silverberg [:bsilverberg]]

Attachment: Web extension with an update_url which installs without error

Comment 4

[Paul Heil]

(In reply to Bob Silverberg [:bsilverberg] from comment #3)
> Created attachment 8765536 [details]
> Web extension with an update_url which installs without error

I've narrowed down the issue.  If you change your update_url to 'http' instead of 'https' then you cannot install the testcase.  Non-secure domains work with unlisted SDK addons so hopefully it should work with Webextensions.

Comment 5

[Bob Silverberg [:bsilverberg]]

Thanks Paul. I tried making that change to my extension and testing on Fx 48. I noticed that Test Pilot was mentioned in the errors, so I tried both with Test Pilot installed and uninstalled. In either case I do now see a message from Firefox in the doorhanger which says "bug1281030Test could not be installed because it is not compatible with Firefox 48.0." With Test Pilot installed I also see similar error messages in the console:

1467057904979	addons.manager	WARN	InstallListener threw exception when calling onNewInstall: TypeError: app is undefined (resource://gre/modules/commonjs/toolkit/loader.js -> resource://testpilot-addon/index.js:536:5) JS Stack trace: [e-mail]:536:5 < [e-mail]:1716:15 < [e-mail]:2976:12 < AddonInstall.prototype.initLocalInstall/</<@XPIProvider.jsm:5319:11 < makeSafe/<@XPIProviderUtils.js:168:17 < [e-mail]:149:5 < this.XPIDatabase.getAddon/<@XPIProviderUtils.js:1119:9 < [e-mail]:937:23 < [e-mail]:816:7 < this.PromiseWalker.scheduleWalkerLoop/<@Promise-backend.js:750:11
1467057904983	addons.manager	WARN	InstallListener threw exception when calling onDownloadCancelled: TypeError: app is undefined (resource://gre/modules/commonjs/toolkit/loader.js -> resource://testpilot-addon/index.js:551:5) JS Stack trace: [e-mail]:551:5 < [e-mail]:1716:15 < [e-mail]:2976:12 < [e-mail]:5422:7 < [e-mail]:6443:5 < [e-mail]:148:11 < [e-mail]:81:3 < [e-mail]:335:5 < [e-mail]:2200:16 < [e-mail]:3394:5 < [e-mail]:110:9 < amManager.prototype.installAddonsFromWebpage/buildNextInstall/<@addonManager.js:152:9 < [e-mail]:179:5 < [e-mail]:1914:11 < this.XPIProvider.getInstallForURL/<@XPIProvider.jsm:3874:7 < makeSafe/<@XPIProvider.jsm:1997:24 < AddonInstall.prototype.initLocalInstall/</<@XPIProvider.jsm:5323:11 < makeSafe/<@XPIProviderUtils.js:168:17 < [e-mail]:149:5 < this.XPIDatabase.getAddon/<@XPIProviderUtils.js:1119:9 < [e-mail]:937:23 < [e-mail]:816:7 < this.PromiseWalker.scheduleWalkerLoop/<@Promise-backend.js:750:11

However without Test Pilot installed I do not see any of those messages, so I think they might be a red herring.

On Fx 49 I get the doorhanger error, but not the console error messages, regardless of Test Pilot.
On Fx 50 I also get the doorhanger error, and this time I see two messages in the console:

1467059113097	addons.xpi	WARN	Updates for add-on [e-mail]">[e-mail] must be provided over HTTPS.
1467059113262	addons.xpi	WARN	Updates for add-on [e-mail]">[e-mail] must be provided over HTTPS.

Is it the case that an update url must have a schema of https, and http is not allowed, and if so might that be the problem?

Comment 6

[Bob Silverberg [:bsilverberg]]

I have confirmed that update_url must contain an https link. I have also updated the MDN docs [1] to specify this. If you change your update_url to be over https it should resolve your issue.

[1] https://developer.mozilla.org/en-US/Add-ons/WebExtensions/manifest.json/applications

Comment 7

[Andy McKay]

Filed https://github.com/mozilla/addons-linter/issues/787 for the AMO linter to raise an error.