1281762 - nsWindowRoot::mPopupNode may keep otherwise closed documents alive

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

I see a document being kept alive via nsWindowRoot::mPopupNode in child process.

http://searchfox.org/mozilla-central/rev/970569ad57ac4436ff31aa2ac63f38ed3ee2932d/layout/base/nsDocumentViewer.cpp#2695
->
http://searchfox.org/mozilla-central/source/dom/base/nsWindowRoot.cpp#379

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

I think we could make mPopupNode a weak ref

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

https://treeherder.mozilla.org/#/jobs?repo=try&revision=feffa0b2ee8e

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8a1a3f39c99b
nsWindowRoot::mPopupNode may keep otherwise closed documents alive, r=enn

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8764566 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: For e10s, bug 1058712 
[User impact if declined]: higher memory consumption and slower cycle collections in some cases
[Describe test coverage new/current, TreeHerder]: NA
[Risks and why]: should be very safe. 
[String/UUID change made/needed]: NA

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8a1a3f39c99b

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8764566 [details] [diff] [review]
patch

Improve the memory usage, taking it.
Should be in 48 beta 4

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/74763893c0f3
https://hg.mozilla.org/releases/mozilla-beta/rev/17911666c98e