1282105 - NoScript extension blocks display of JSON data

Status: RESOLVED FIXED

(DevTools :: JSON Viewer, defect, P4)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I have NoScript 2.9.0.11 installed and whenever I open a URL which returns JSON data the page is displayed as white. Once NoScript gets disabled the json viewer works correctly.

I'm not exactly sure what exactly is causing this misbehavior. If its NoScript or the internal json viewer.

Comment 1

[Frankie]

Reporter, can you provide an example URL?

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Sorry that I missed to add an example for it. Here you have one:

https://treeherder.mozilla.org/api/project/mozilla-central/jobs/?exclusion_profile=False&format=json&machine_platform_os=mac&option_collection_hash=102210fe594ee9b33d82058545b1ed14f4c8206e&result_set_id=5319

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Henrik Skupin (:whimboo) from comment #0)
> I have NoScript 2.9.0.11 installed and whenever I open a URL which returns
> JSON data the page is displayed as white. Once NoScript gets disabled the
> json viewer works correctly.
JSON Viewer is using JavaScript to render the page so, blocking JS breaks it.
There is no plan currently that would allow running JSON Viewer without JS.

Honza

Comment 4

[Giorgio Maone [:ma1]]

I'm gonna work around by checking whether the content type changed from JSON to text/html just before blocking scripts, like this:

<snippet>
let channel = docShell.currentDocumentChannel;
if (channel instanceof Ci.nsIHttpChannel) {
  let originalContentType = channel.getResponseHeader("Content-Type");
  if (/\/json(?:;|^)/i.test(originalContentType) && channel.contentType === "text/html") {
    blockJS = false;
  }
}
</snippet>

Of course I'd really prefer something less hackish and working also on non-HTTP channels, e.g. you might set some flag / property on the channel in your jsonview-converter at https://dxr.mozilla.org/mozilla-central/rev/4c05938a64a7fde3ac2d7f4493aee1c5f2ad8a0a/devtools/client/jsonview/converter-child.js#98

Comment 5

[Oriol Brufau [:Oriol]]

After bug 1366239 you should at least see the raw JSON.

Comment 6

[Oriol Brufau [:Oriol]]

NoScript fixed this in version 5.0.4
https://addons.mozilla.org/firefox/addon/noscript/versions/5.0.4

> Fixed JSON viewer working only on JavaScript-enabled URLs