Closed Bug 1283457 Opened 8 years ago Closed 8 years ago

Update username event from panel should spread to the stores

Categories

(Hello (Loop) :: Client, defect)

Product:
Hello (Loop)
Component:
Client
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: fcampo, Assigned: andreio)

References

Details

Attachments

(1 file)

[loop] piatra:1283457-update-username > mozilla:akita
40 bytes, text/x-github-pull-request
fcampo
: review+
Details | Review 
From bug 1279042 comment 4

We already show the username from localStorage as user identity [bug 1279042], but when user changes its username from the panel, the event does not reach the stores, so the new name it's not shown on chat/presence.

Possible implementation mentioned on bug 1279042 comment 3
QA Contact: andrei.br92
Assignee: nobody → andrei.br92
QA Contact: andrei.br92
Attachment #8768276 - Flags: review?(standard8)
Attachment #8768276 - Flags: review?(fernando.campo)
Comment on attachment 8768276 [details] [review]
[loop] piatra:1283457-update-username > mozilla:akita

Left some comments on GH. It looks good, but we need to subscribe from ParticipantStore too so presence is updated.

Please ask for review when changes are done.
Attachment #8768276 - Flags: review?(fernando.campo)
Attachment #8768276 - Flags: review?(standard8)
Comment on attachment 8768276 [details] [review]
[loop] piatra:1283457-update-username > mozilla:akita

code looks good, just need to add an updateRoomInfo call so the name change is reflected on the presence indicator for the rest of the connected peers (and a test for it, please)
Attachment #8768276 - Flags: review+
https://github.com/mozilla/loop/pull/559
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: