Closed
Bug 1283552
Opened 8 years ago
Closed 8 years ago
Port bug 1247972 to comm-central (reduce the codesize hit from changing NS_ProxyRelease to take already_AddRefed<T>) - nsProxyRelease.h(95): error C2594: 'argument': ambiguous conversions from 'nsLDAPConnection *' to 'nsISupports *'
Categories
(MailNews Core :: LDAP Integration, defect)
MailNews Core
LDAP Integration
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 50.0
People
(Reporter: Paenglab, Assigned: mkmelin)
References
Details
Attachments
(1 file)
|
1.31 KB,
patch
|
aleth
:
review+
|
Details | Diff | Splinter Review |
Error when building: 43:05.59 z:/Mozilla/TB/dist/include\nsProxyRelease.h(95): error C2594: 'argument': ambiguous conversions from 'nsLDAPConnection *' to 'nsISu pports *' 43:05.59 z:/Mozilla/TB/dist/include\nsProxyRelease.h(124): note: see reference to function template instantiation 'void detail::ProxyRelease Chooser<true>::ProxyRelease<T>(nsIEventTarget *,already_AddRefed<T>,bool)' being compiled This comes from bug 1247972. Back-out of it let's build TB successfully.
|
Assignee | |
Comment 1•8 years ago
|
||
This builds for me
Assignee: nobody → mkmelin+mozilla
Status: NEW → ASSIGNED
Attachment #8767065 -
Flags: review?(aleth)
|
|
Assignee | |
Updated•8 years ago
|
Severity: normal → blocker
|
|
Assignee | |
Updated•8 years ago
|
Summary: nsProxyRelease.h(95): error C2594: 'argument': ambiguous conversions from 'nsLDAPConnection *' to 'nsISu pports *' → Port bug 1247972 to comm-central (reduce the codesize hit from changing NS_ProxyRelease to take already_AddRefed<T>) - nsProxyRelease.h(95): error C2594: 'argument': ambiguous conversions from 'nsLDAPConnection *' to 'nsISupports *'
|
||
Updated•8 years ago
|
Attachment #8767065 -
Flags: review?(aleth) → review+
|
|
||
Comment 2•8 years ago
|
||
https://hg.mozilla.org/comm-central/rev/b955d1f90a588d5deed96ff3d01be8dc1fbdd91f Bug 1283552 - Port bug 1247972 to comm-central (reduce the codesize hit from changing NS_ProxyRelease to take already_AddRefed<T>) - nsProxyRelease.h(95): error C2594: 'argument': ambiguous conversions from 'nsLDAPConnection *' to 'nsISupports *' rs=aleth
|
|
||
Updated•8 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 50.0
You need to log in
before you can comment on or make changes to this bug.
Description
•