Closed
Bug 1283559
Opened 8 years ago
Closed 8 years ago
Remove obsolete OS X version checks in ipc/glue and dom/plugins/ipc
Categories
(Core :: IPC, defect, P3)
Tracking
()
RESOLVED
FIXED
mozilla50
Tracking | Status | |
---|---|---|
firefox50 | --- | fixed |
People
(Reporter: stefanh, Assigned: stefanh)
References
Details
Attachments
(1 file, 1 obsolete file)
3.49 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•8 years ago
|
||
bsmedberg, mind take a look at this? This code is obsolete now, and I want to remove the version checks from nsCocoaFeatures.h in bug 1282251.
Attachment #8766859 -
Flags: review?(benjamin)
Priority: -- → P3
Comment 2•8 years ago
|
||
Comment on attachment 8766859 [details] [diff] [review] Remove obsolete code >diff --git a/dom/plugins/ipc/PluginInstanceChild.cpp b/dom/plugins/ipc/PluginInstanceChild.cpp >- bool avoidCGCrashes = !nsCocoaFeatures::OnMountainLionOrLater() && >- (GetQuirks() & QUIRK_FLASH_AVOID_CGMODE_CRASHES); >+ bool avoidCGCrashes = GetQuirks() & QUIRK_FLASH_AVOID_CGMODE_CRASHES; This logic looks wrong. The avoidCGCrashes quirk was only for old versions of MacOS, so avoidCGCrashes should always be false now (and we could remove the quirk code entirely.
Attachment #8766859 -
Flags: review?(benjamin) → review-
Assignee | ||
Comment 3•8 years ago
|
||
(In reply to Benjamin Smedberg [:bsmedberg] from comment #2) > and we could remove the quirk code entirely. Mind having a separate bug for that?
Comment 4•8 years ago
|
||
I don't particularly care.
Assignee | ||
Comment 5•8 years ago
|
||
Not sure how I missed this... I'll file a bug for the quirk code removal.
Attachment #8766859 -
Attachment is obsolete: true
Attachment #8768457 -
Flags: review?(benjamin)
Updated•8 years ago
|
Attachment #8768457 -
Flags: review?(benjamin) → review+
Pushed by stefanh@inbox.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/098b3b8860dc Remove obsolete OS X version checks in ipc/glue and dom/plugins/ipc. r=bsmedberg.
Assignee | ||
Comment 7•8 years ago
|
||
Filed bug 1284939 for the quirk code removal.
Comment 8•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/098b3b8860dc
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•