1283582 - Fennec displays a context menu on long-press, even if the 'contextmenu' is cancelled by web content

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Toolbar, defect, P2)

Description

[Kartikaya Gupta (email:[e-mail])]

This appears to be a long-standing issue in Fennec, I can repro in current release (47) through to Nightly (50). STR:
1) Load http://people.mozilla.org/~kgupta/touch.html
2) Tap on the "contextmenu" checkbox. This will cause the page to call preventDefault() on contextmenu events
3) Long-press on the "Link to nowhere"

ER: No browser context menu is shown
AR: Browser shows a context menu

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1283582 - Stop displaying the context menu in Fennec if web content did a preventDefault on the event.

Review commit: https://reviewboard.mozilla.org/r/61604/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/61604/

Comment 2

[:Margaret Leibovic]

Comment on attachment 8766884 [details]
Bug 1283582 - Stop displaying the context menu in Fennec if web content did a preventDefault on the event.

https://reviewboard.mozilla.org/r/61604/#review59086

Sounds reasonable to me.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f0c70bfa8917
Stop displaying the context menu in Fennec if web content did a preventDefault on the event. r=margaret

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f0c70bfa8917

Comment 5

[Alex Caziuc]

Verified using:
Device: Samsung Galaxy S6 Edge (Android 5.1.1)
Build: Firefox for Android Nigtly - 50.0a1(2016-07-06)

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8766884 [details]
Bug 1283582 - Stop displaying the context menu in Fennec if web content did a preventDefault on the event.

Approval Request Comment
[Feature/regressing bug #]: Long-standing bug
[User impact if declined]: Pages that prevent the browser from showing a context menu (often because they have their own context menu) will be unable to. The user might end up with both the page's context menu and the browser's context menu which can be annoying. Shouldn't be a huge issue though, as the browser's context menu can be easily dismissed and then the user should be able to access the page's context menu.
[Describe test coverage new/current, TreeHerder]: none
[Risks and why]: Fairly low risk, this change brings Fennec behaviour in line with what desktop and other browsers do.
[String/UUID change made/needed]: none

Comment 7

[Gerry Chang [:gchang]]

Comment on attachment 8766884 [details]
Bug 1283582 - Stop displaying the context menu in Fennec if web content did a preventDefault on the event.

This patch fixes a UI behavior. Take it in 48 beta 7 and aurora.

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/a5b1d40aa344

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/24787f5d46cf

Comment 10

[u549602]

Verified as fixed on latest Beta 48.0b9 and Aurora 49.0a2 (2016-07-18) but if page is reloaded, the bug can be reproduced.