1284275 - Upgrade AngularJS to 1.4.9 and AngularUI Bootstrap to 1.3.3

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect)

Description

[crosscent]

Angular bootstrap 1.3.3 has some features that would be nice to have in. For example, boundary-link-numbers for uib-pagination.

Comment 1

[crosscent]

Angular bootstrap 1.3.3 requires $q.resolve, which is only available on AngularJS 1.4.5 or above. 

emorley, and wlach have suggested that we upgrade to the latest version in 1.4, which is 1.4.9.

Comment 2

[GitHub Autolander Bot]

Attachment: [treeherder] crosscent:Bug1284275 > mozilla:master

Comment 3

[William Lachance (:wlach)]

Comment on attachment 8767715 [details] [review]
[treeherder] crosscent:Bug1284275 > mozilla:master

Looks good to me. I would personally separate this into two commits (one to bump the angular version, another to bump angular bootstrap) but it's not that big a deal. Let's just get this landed so you can continue working. :)

Comment 4

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/b1a82fba5563248340869c40d4bb042b67b0deb2
Bug 1284275 - Upgrade AngularJS and it's dependencies to 1.4.9, and upgrade AngularUI Bootstrap to 1.3.3 (#1644)

Comment 5

[William Lachance (:wlach)]

Did some preliminary testing and this looks ok. I think it's a pretty low risk change, but we should run moztrap before the next deploy just to be sure.

Comment 6

[GitHub Autolander Bot]

Attachment: [treeherder] wlach:1284275-2 > mozilla:master

Comment 7

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/eb91d078300e7392cd01d63a67f76ab9a9103ccf
Bug 1284275 - Fix modal dialogs in perfherder alert views (#1683)

Comment 8

[GitHub Autolander Bot]

Attachment: [treeherder] wlach:1284275-3 > mozilla:master

Comment 9

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/7b08f1e916ba62574eed5f92aa506aa5de25250a
Bug 1284275 - Another fix for reassign perf alerts dialog (#1693)