1284494 - fork _nav_support_menu and move changes from bug 1231954 there

Status: RESOLVED FIXED

(MozReview Graveyard :: Review Board: User Interface, defect)

Description

[:glob ✱]

when i reviewed bug 1231954 i forgot about:

"When making changes to a built-in review board template, forking the template file and changing the view to reference your new modified file is preferred - this will lessen merge conflicts when rebasing all of our changes on an updated RB (and allow us to integrate new upstream changes to the template in one go)"

let's revert _nav_support_menu and fork it here.

Comment 1

[:glob ✱]

Attachment: MozReview: revert changes from d1a3a686b1e0 (bug 1284494);

The changes made in bug 1231954 will be moved to a forked copy of that
template.

Review commit: https://reviewboard.mozilla.org/r/62366/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/62366/

Comment 2

[:glob ✱]

Attachment: MozReview: fork _nav_support_menu template (bug 1284494)

Review commit: https://reviewboard.mozilla.org/r/62368/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/62368/

Comment 3

[:glob ✱]

Attachment: MozReview: Add link for keyboard shortcuts (bug 1284494)

Review commit: https://reviewboard.mozilla.org/r/62370/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/62370/

Comment 4

[Steven MacLeod [:smacleod]]

Comment on attachment 8767982 [details]
MozReview: revert changes from d1a3a686b1e0 (bug 1284494);

https://reviewboard.mozilla.org/r/62366/#review59200

Comment 5

[Steven MacLeod [:smacleod]]

Comment on attachment 8767983 [details]
MozReview: fork _nav_support_menu template (bug 1284494)

https://reviewboard.mozilla.org/r/62368/#review59202

"r?smmacleod" eh? Someone hasn't been using the draft state ;)

Comment 6

[Steven MacLeod [:smacleod]]

Comment on attachment 8767984 [details]
MozReview: Add link for keyboard shortcuts (bug 1284494)

https://reviewboard.mozilla.org/r/62370/#review59204

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/webtools/reviewboard/rev/31634fc85874
MozReview: revert changes from d1a3a686b1e0 ; r=smacleod
https://hg.mozilla.org/webtools/reviewboard/rev/53254c76f563
MozReview: fork _nav_support_menu template r=smacleod
https://hg.mozilla.org/webtools/reviewboard/rev/5d84ec273f3a
MozReview: Add link for keyboard shortcuts r=smacleod