1284587 - Distinguish reader view items in bookmarks panel telemetry

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Reading List, defect, P1)

Description

[Andrzej Hunt :ahunt]

When opening a bookmark we don't distinguish between normal bookmarks, and offline reader view bookmarks.

We could potentially also distinguish screenshots too (bug 1251058), but they're exclusively in their own folder, so perhaps that's not necessary (whereas reader view items can be in the root folder).

Comment 1

[Andrzej Hunt :ahunt]

Attachment: Bug 1284587 - Distinguish normal from reader view bookmarks in telemetry

We want to be able to detect when we've opened a reader view item. Note: this is
independent of whether or not we're in the Reading List smartfolder: it's possible
to open reader view bookmarks from any real bookmark folder, or the smartfolder.

Review commit: https://reviewboard.mozilla.org/r/62544/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/62544/

Comment 2

[Chenxia Liu [:liuche]]

Comment on attachment 8768217 [details]
Bug 1284587 - Distinguish normal from reader view bookmarks in telemetry

https://reviewboard.mozilla.org/r/62544/#review60460

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

Looks like we can land this? I'll set this to P1.

Comment 4

[Barbara Bermes [:barbara] - NI please!]

Yes, please this needs to go in asap. We need this for KPI measuring and to give some data to marketing (before/after). Thanks

Comment 5

[Andrzej Hunt :ahunt]

https://hg.mozilla.org/integration/fx-team/rev/d70bb3bdb5cc14df566cc1ed2c12f38e184a2f54
Bug 1284587 - Distinguish normal from reader view bookmarks in telemetry r=liuche

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d70bb3bdb5cc

Comment 7

[Andrzej Hunt :ahunt]

Comment on attachment 8768217 [details]
Bug 1284587 - Distinguish normal from reader view bookmarks in telemetry

Approval Request Comment
[Feature/regressing bug #]: n/a
[User impact if declined]: no user impact. Telemetry impact: we will be unable to distinguish loading of normal vs reader-view bookmarks after the reading list migration.
[Describe test coverage new/current, TreeHerder]: manual testing, patch has been on nightly for past 2 weeks.
[Risks and why]: Low risk minor change to telemetry probe to send different "extra" when opening reader view bookmarks.
[String/UUID change made/needed]: None.

Comment 8

[Gerry Chang [:gchang]]

Comment on attachment 8768217 [details]
Bug 1284587 - Distinguish normal from reader view bookmarks in telemetry

This patch can help to collect data after the reading list migration. Take it in 49 beta. Should be in 49 beta 2.

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d5e5b71813bf