Closed Bug 1285409 Opened 8 years ago Closed 8 years ago

if we are going to descend into a frame anyway we may as well store oof data for it so we have the right clip

Categories

(Core :: Web Painting, defect)

Product:
Core
Component:
Web Painting
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla50
Tracking Flags:
Tracking Status
firefox48 --- fixed
firefox49 --- fixed
firefox50 --- fixed

People

(Reporter: tnikkel, Assigned: tnikkel)

References

Details

Attachments

(1 file, 1 obsolete file)

patch
1.61 KB, patch
mattwoodrow
: review+
gchang
: approval-mozilla-aurora+
gchang
: approval-mozilla-beta+
Details | Diff | Splinter Review 
This fixes an assert on try server with bug 1271714.
Attached patch patch (obsolete) — — Splinter Review 

        Attachment #8769010 -
        Flags: review?(matt.woodrow)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch
        — 
          — Splinter Review
      

    


  

        Attachment #8769010 -
        Attachment is obsolete: true

        Attachment #8769010 -
        Flags: review?(matt.woodrow)

        Attachment #8769018 -
        Flags: review?(matt.woodrow)

        Attachment #8769018 -
        Flags: review?(matt.woodrow) → review+

    
    

    
  
Pushed by tnikkel@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b82748351785
Store out of flow data for frames we are going to descent into anyways (despite no intersection with the dirty rect) so we have the correct clip for them. r=mattwoodrow

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/b82748351785
Status: NEW → RESOLVED
Closed: 8 years ago

          status-firefox50:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50

    
    

    
  
Comment on attachment 8769018 [details] [diff] [review]
patch

Needed for bug 1276467.

Approval Request Comment
[Feature/regressing bug #]: none
[User impact if declined]: extra cursor gunk in popular web based code editors
[Describe test coverage new/current, TreeHerder]: none
[Risks and why]: this patch is safe
[String/UUID change made/needed]: none

        Attachment #8769018 -
        Flags: approval-mozilla-beta?

        Attachment #8769018 -
        Flags: approval-mozilla-aurora?

    
    

    
  
Comment on attachment 8769018 [details] [diff] [review]
patch

Review of attachment 8769018 [details] [diff] [review]:
-----------------------------------------------------------------

This patch fixes preserve3d asserts and is needed for bug 1276467. Take it in 48 beta 8 and aurora.

        Attachment #8769018 -
        Flags: approval-mozilla-beta?

        Attachment #8769018 -
        Flags: approval-mozilla-beta+

        Attachment #8769018 -
        Flags: approval-mozilla-aurora?

        Attachment #8769018 -
        Flags: approval-mozilla-aurora+
Component: Layout: View Rendering → Layout: Web Painting

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: