128567 - need to be able to set / get any attributes on nsAbCardProperties, not just the "standard" ones.

Status: RESOLVED EXPIRED

(SeaMonkey :: MailNews: Address Book & Contacts, defect)

Description

[(not reading, please use [e-mail] instead)]

SetCardValue() with generic column names needs to work properly on 
nsAbCardProperty, not just mdb card properties

cavin needs this for http://bugscape.mcom.com/show_bug.cgi?id=11575, and I 
think it would simplify some existing ab js / C++.

Comment 1

[(not reading, please use [e-mail] instead)]

adding nsbeta1+, since the bugscape bug has that.

Comment 2

[(not reading, please use [e-mail] instead)]

Attachment: moz part of the fix

Comment 3

[(not reading, please use [e-mail] instead)]

Attachment: ns side of the fix

Comment 4

[(not reading, please use [e-mail] instead)]

Attachment: moz side of the fix, this time without hack changes to test the code

Comment 5

[(not reading, please use [e-mail] instead)]

hmm, I think this approach is flawed.  let me go back to the drawing board.

Comment 6

[(not reading, please use [e-mail] instead)]

this approach has some flaws.  I'll meeting with cavin.  I think a cleaner fix 
can be made to nsAbSync.cpp alone.  invalid, I don't plan on making this work.

Comment 7

[Ninoschka Baca]

Verified Invalid.

Comment 8

[(not reading, please use [e-mail] instead)]

reopening.

cavin and I have a fix going for bugscape bug #11575, but it could have been a
lot simpler if the addressbook wasn't such a mess.

here's some background:

there are abstract cards (ones that aren't in the db) and db cards.

we should be able to get / set properties on abstract cards, even if the
properties aren't the "well know" ones, like first name, last name, etc.

we need this for generic properties, like _AimScreenName

Then, we'd need to fix copycard() so that when copying a card, all values would
get copied into the db.

ugh, it's a big mess, and we're not going to get to it for 1.0

but one day, maybe.  let me just say that the addressbook architecture is a
giant mess.  dmose points out that is getting better, but it still hurts.

one day, we'll be able to make this kind of clean up

Comment 9

[(not reading, please use [e-mail] instead)]

when we get to this, we should also do this:

on nsIAbMDBCard, remove:

	wstring getStringAttribute(in string name);
	void setStringAttribute(in string name, in wstring value);

and instead just override these existing methods of nsIAbCard

	wstring getCardValue(in string name);
	void setCardValue(in string attrname, in wstring value);

this will require some code fixing in the ns tree, too.

wee!  I hate the addressbook.

Comment 10

[Robert Kaiser]

MASS-CHANGE:
This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614

Comment 11

[Robert Kaiser]

MASS-CHANGE:
This bug report is registered in the SeaMonkey product, but still has no comment since the inception of the SeaMonkey project 5 years ago.

Because of this, we're resolving the bug as EXPIRED.

If you still can reproduce the bug on SeaMonkey 2 or otherwise think it's still valid, please REOPEN it and if it is a platform or toolkit issue, move it to the according component.

Query tag for this change: EXPIRED-20100420