1286157 - [TSF] TSFTextStore should use relative offset query when there are pending changes

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I realized that TSFTextStore should use relative offset from insertion point query when there are pending changes since the offset of query by TSF/TIP is expected in the cached content.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1286157 TSFTextStore should use insertion point relative offset query when cached contents for TSF and actual content (or content cache) are different

Review commit: https://reviewboard.mozilla.org/r/63842/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/63842/

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

FYI: I won't land the patch without the fix of bug 1257446 since this patch makes the symptom of bug 1257446 worse.

Comment 3

[Makoto Kato [:m_kato]]

Comment on attachment 8770381 [details]
Bug 1286157 TSFTextStore should use insertion point relative offset query when cached contents for TSF and actual content (or content cache) are different

https://reviewboard.mozilla.org/r/63842/#review60962

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8770381 [details]
Bug 1286157 TSFTextStore should use insertion point relative offset query when cached contents for TSF and actual content (or content cache) are different

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63842/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d8e515832579
TSFTextStore should use insertion point relative offset query when cached contents for TSF and actual content (or content cache) are different r=m_kato

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d8e515832579