Closed
Bug 1286489
Opened 8 years ago
Closed 8 years ago
[TSF] Don't put \r\n directly to log file
Categories
(Core :: Widget: Win32, defect)
Tracking
()
RESOLVED
FIXED
mozilla50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: masayuki, Assigned: masayuki)
Details
(Keywords: inputmethod)
Attachments
(1 file)
When I'm debugging, \r\n are very annoying to breaking lines in the log file. We should replace them (and \t, perhaps, more?) with "\\n", etc.
|
Assignee | |
Comment 1•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ae96f0dd48ec
|
|
Assignee | |
Comment 2•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/64038/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/64038/
Attachment #8770605 -
Flags: review?(m_kato)
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8770605 [details] Bug 1286489 TSFTextStore.cpp and ContentCache.cpp shouldn't put \n, \r and \t to log file directly https://reviewboard.mozilla.org/r/64038/#review61180
Attachment #8770605 -
Flags: review?(m_kato) → review+
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/369cab5b9f2e TSFTextStore.cpp and ContentCache.cpp shouldn't put \n, \r and \t to log file directly r=m_kato
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/369cab5b9f2e
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•