1287290 - Use ScopedAutoSECItem in PSM more

Status: RESOLVED FIXED

(Core :: Security: PSM, defect, P1)

Description

[:Cykesiopka]

ScopedAutoSECItem is useful for:
1. Removing manual memory management.
2. Getting rid of this pattern:
   > UniqueSECItem item(SECITEM_AllocItem(nullptr, nullptr, 0));
   While this pattern works, ScopedAutoSECItem is slightly superior in that it
   doesn't unnecessarily cause a SECItem to be allocated from the heap.

Comment 1

[:Cykesiopka]

Attachment: Bug 1287290 - Use ScopedAutoSECItem in PSM more.

ScopedAutoSECItem is useful for:
1. Removing manual memory management.
2. Getting rid of this pattern:
   > UniqueSECItem item(SECITEM_AllocItem(nullptr, nullptr, 0));
   While this pattern works, ScopedAutoSECItem is slightly superior in that it
   doesn't unnecessarily cause a SECItem to be allocated from the heap.

Review commit: https://reviewboard.mozilla.org/r/66784/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/66784/

Comment 2

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Comment on attachment 8774252 [details]
Bug 1287290 - Use ScopedAutoSECItem in PSM more.

https://reviewboard.mozilla.org/r/66784/#review63756

Awesome - r=me.

Comment 3

[:Cykesiopka]

Thanks!

https://treeherder.mozilla.org/#/jobs?repo=try&revision=685e4959c12a

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f8a4ca6608d9
Use ScopedAutoSECItem in PSM more. r=dkeeler

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f8a4ca6608d9