Closed
Bug 1287295
Opened 8 years ago
Closed 8 years ago
Fix filter icon in Canvas
Categories
(DevTools Graveyard :: Canvas Debugger, defect)
DevTools Graveyard
Canvas Debugger
Tracking
(firefox50 affected, firefox51 affected, firefox52 verified)
VERIFIED
FIXED
Firefox 52
People
(Reporter: magicp.jp, Assigned: Towkir, Mentored)
Details
(Keywords: good-first-bug)
Attachments
(2 files)
45.61 KB,
image/png
|
Details | |
802 bytes,
patch
|
ntim
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:50.0) Gecko/20100101 Firefox/50.0 Build ID: 20160716030215 Steps to reproduce: 1. Start Nightly 2. Go to "http://helloracer.com/webgl/" 3. Open DevTools > Canvas 4. Confirm filter icon in inputbox Actual results: Using search icon (search.svg) Expected results: Filter icon (filter.svg)
Has STR: --- → yes
status-firefox50:
--- → affected
Component: Untriaged → Developer Tools: Canvas Debugger
OS: Unspecified → All
Hardware: Unspecified → All
status-firefox51:
--- → affected
Comment 1•8 years ago
|
||
At https://dxr.mozilla.org/mozilla-central/source/devtools/client/canvasdebugger/canvasdebugger.xul#113 replace devtools-searchinput with devtools-filterinput
Mentor: ntim.bugs
Keywords: good-first-bug
status-firefox52:
--- → affected
Assignee | ||
Comment 2•8 years ago
|
||
Hope this helps :)
Comment 3•8 years ago
|
||
Comment on attachment 8803299 [details] [diff] [review] filter_icon_vs_search_icon.patch Review of attachment 8803299 [details] [diff] [review]: ----------------------------------------------------------------- Works great, thanks for the patch!
Attachment #8803299 -
Flags: review?(ntim.bugs) → review+
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/d188cf31d797 Fix filter icon in Canvas by replacing the search icon. r=ntim
Keywords: checkin-needed
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d188cf31d797
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Comment 6•8 years ago
|
||
I have reproduced this bug with nightly 50.0a1 (2016-07-16) on windows 10, 32 bit. The bug’s fix is now verified on Latest Nightly 52.0a1. Build Id: 20161028030204. User agent: Mozilla/5.0 (Windows NT 10.0; rv:52.0) Gecko/20100101 Firefox/52.0. [bugday-20161026]
Updated•8 years ago
|
Status: RESOLVED → VERIFIED
Updated•6 years ago
|
Product: Firefox → DevTools
Updated•5 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•