1287299 - TEST-UNEXPECTED-TIMEOUT | toolkit/components/search/tests/xpcshell/test_engineUpdate.js

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Jorg K (CEST = GMT+2)]

TEST-UNEXPECTED-TIMEOUT | toolkit/components/search/tests/xpcshell/test_engineUpdate.js | Test timed out

First seen on C-C on 2016-07-15 here:
https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=752a2122c521c5115049f4fbb4229484a05b2c2c&selectedJob=42101

Looks like this is due to bug 1274545.

Florian, can you please give us a hand here. Since this is about search engines, maybe this test should just be disabled for TB.

Comment 1

[Jorg K (CEST = GMT+2)]

No reply from Florian, perhaps Ian can shed some light onto this. We're seeing the test failure on Treeherder comm-central and comm-aurora now since bug 1274545 got uplifted to FF Aurora.

Comment 2

[Jorg K (CEST = GMT+2)]

After the branch day yesterday, we have this failure on C-C, C-A and C-B. Time to do something about it.

Comment 3

[Florian Quèze [:florian]]

The difference between Thunderbird and Firefox here is: https://hg.mozilla.org/comm-central/annotate/c23005eea70868e2031e9e0a35c389cc3b00559c/mail/app/profile/all-thunderbird.js#l811

Possible ways forward:
- remove this line from all-thunderbird.js so that Thunderbird has the default |true| value, like other toolkit apps.
- change the test to set the pref to true at the beginning.
- change the test to return early if the pref is set to false.

Comment 4

[Jorg K (CEST = GMT+2)]

Attachment: Removed preference.

Let's see whether Florian's first option works.

Here's a try:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=9aad3fa0c576
Pushed Kent's patch from bug 1290541 on top so it hopefully comes out all green.

Comment 5

[Jorg K (CEST = GMT+2)]

Comment on attachment 8777438 [details] [diff] [review]
Removed preference.

That try came out
B - orange
X - green
Z - red
but it basically worked, so should we just remove the preference?

Comment 6

[aleth [:aleth]]

Comment on attachment 8777438 [details] [diff] [review]
Removed preference.

Review of attachment 8777438 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/app/profile/all-thunderbird.js
@@ -807,5 @@
>  pref("browser.search.order.US.1", "data:text/plain,browser.search.defaultenginename.US=Bing");
>  pref("browser.search.order.US.2", "data:text/plain,browser.search.defaultenginename.US=Yahoo");
>  pref("browser.search.order.US.3", "data:text/plain,browser.search.defaultenginename.US=");
>  
> -// XXX Don't update yet, until we've verified how that affects us.

How does it affect TB?

@@ +811,2 @@
>  // Check whether we need to perform engine updates every 6 hours
>  pref("browser.search.update.interval", 21600);

Do these other browser.search prefs override defaults too or can they be removed as well?

Comment 7

[Jorg K (CEST = GMT+2)]

(In reply to aleth [:aleth] from comment #6)
> > -// XXX Don't update yet, until we've verified how that affects us.
> How does it affect TB?
I wouldn't have a clue. And I wouldn't have a clue on how to find out either.
Since the test passes in TB, well, something must be working.

> >  // Check whether we need to perform engine updates every 6 hours
> >  pref("browser.search.update.interval", 21600);
> Do these other browser.search prefs override defaults too or can they be
> removed as well?
I was asking myself the same question:
https://dxr.mozilla.org/comm-central/source/mozilla/modules/libpref/init/all.js#5295
appears to define the same value, so our entry in all-thunderbird.js can possibly go.

Comment 8

[Florian Quèze [:florian]]

Comment on attachment 8777438 [details] [diff] [review]
Removed preference.

Review of attachment 8777438 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/app/profile/all-thunderbird.js
@@ +811,2 @@
>  // Check whether we need to perform engine updates every 6 hours
>  pref("browser.search.update.interval", 21600);

We can remove this too.

Comment 9

[Jorg K (CEST = GMT+2)]

C-C,    TB 51: https://hg.mozilla.org/comm-central/rev/9e6cd9221dc4
Beta,   TB 49: https://hg.mozilla.org/releases/comm-beta/rev/0937a8d42af7
Aurora, TB 50: coming.

Comment 10

[Jorg K (CEST = GMT+2)]

Aurora, TB 50: https://hg.mozilla.org/releases/comm-aurora/rev/9b7fd654f3cc