1287351 - OdinMonkey: MIPS: Implement many simple operations in the MacroAssembler

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect, P3)

Description

[hev [:hev]]

See Bug 1278283

Comment 1

[hev [:hev]]

Attachment: Part 1 - Expose max and min in the MacroAssembler + move code.

Comment 2

[hev [:hev]]

Attachment: Part 2 - Implement many simple operations in the MacroAssembler.

Comment 3

[hev [:hev]]

Attachment: Part 1 - Expose max and min in the MacroAssembler + move code.

Comment 4

[Lars T Hansen [:lth]]

Comment on attachment 8771840 [details] [diff] [review]
Part 2 - Implement many simple operations in the MacroAssembler.

Review of attachment 8771840 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/mips-shared/MacroAssembler-mips-shared-inl.h
@@ +276,5 @@
> +MacroAssembler::absFloat32(FloatRegister src, FloatRegister dest)
> +{
> +    if (src != dest)
> +        as_movs(dest, src);
> +    as_abss(dest, dest);

Not that it's any of my business, but the MIPS manual suggests that as_abss(dest, src) would be fine here, you don't need the MOVS.  (I'm not a MIPS expert.)

@@ +284,5 @@
> +MacroAssembler::absDouble(FloatRegister src, FloatRegister dest)
> +{
> +    if (src != dest)
> +        as_movd(dest, src);
> +    as_absd(dest, dest);

Ditto.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6ac147f1004e
IonMonkey: MIPS: Expose max and min in the MacroAssembler + move code. r=lth
https://hg.mozilla.org/integration/mozilla-inbound/rev/d19427e7135c
OdinMonkey: MIPS: Implement many simple operations in the MacroAssembler. r=lth

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6ac147f1004e
https://hg.mozilla.org/mozilla-central/rev/d19427e7135c