Closed
Bug 1287362
Opened 8 years ago
Closed 8 years ago
Don't use Preferences from CompositorLRU
Categories
(Core :: Graphics: Layers, defect)
Core
Graphics: Layers
Tracking
()
RESOLVED
FIXED
mozilla50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: dvander, Assigned: dvander)
References
(Blocks 1 open bug)
Details
(Whiteboard: [gfx-noted])
Attachments
(1 file, 1 obsolete file)
|
16.92 KB,
patch
|
mattwoodrow
:
review+
|
Details | Diff | Splinter Review |
This breaks GPU process.
|
Assignee | |
Comment 1•8 years ago
|
||
gfxPrefs is initialized after the layout module, so I had to move CompositorLRU::Init. Alternately we could just delete the whole thing since it's a b2g-only optimization.
Attachment #8771852 -
Flags: review?(matt.woodrow)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8771852 [details] [diff] [review] patch Review of attachment 8771852 [details] [diff] [review]: ----------------------------------------------------------------- I would also be ok with deleting it.
Attachment #8771852 -
Flags: review?(matt.woodrow) → review+
Pushed by danderson@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/b3924432ba21 Don't access Preferences from CompositorLRU. (bug 1287362, r=mattwoodrow)
|
||
Comment 4•8 years ago
|
||
backed out for crashes like https://treeherder.mozilla.org/logviewer.html#?job_id=32071114&repo=mozilla-inbound
Flags: needinfo?(dvander)
Backout by cbook@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/777e1b279e39 Backed out changeset b3924432ba21 for xpcshell crashes
|
|
Assignee | |
Comment 6•8 years ago
|
||
Two strikes, let's remove it.
Attachment #8771852 -
Attachment is obsolete: true
Flags: needinfo?(dvander)
Attachment #8772631 -
Flags: review?(matt.woodrow)
|
|
||
Updated•8 years ago
|
Attachment #8772631 -
Flags: review?(matt.woodrow) → review+
Pushed by danderson@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/ddbf5e3673c4 Remove CompositorLRU and associated code. (bug 1287362, r=mattwoodrow)
|
||
Updated•8 years ago
|
Whiteboard: [gfx-noted]
|
|
||
Comment 8•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/ddbf5e3673c4
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•