1287461 - Can't request needinfo from someone when I'm needinfo'd on a bug

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, defect)

Description

[:Gijs (he/him)]

Sometimes I want to keep my own needinfo when also requesting info from other people. The modal UI gives me no way to do that, because my only options are "clear needinfo" and "redirect needinfo", not "keep needinfo and also request needinfo from these other people".

Comment 1

[Xidorn Quan [:xidorn] UTC+11]

It doesn't seem to be Modal UI specific. It exists even without enabling Modal.

And yeah, this is annoying. In addition, if people do not notice that "Need more information from" changes to "Redirect my needinfo request to" when they uncheck "Clear the needinfo request for", they may clear the needinfo request without knowing that, which I've met several times before.

Comment 2

[David Lawrence [:dkl]]

Attachment: 1287461_1.patch

Comment 3

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8813392 [details] [diff] [review]
1287461_1.patch

Review of attachment 8813392 [details] [diff] [review]:
-----------------------------------------------------------------

r=dylan

fix nit on commit :)

::: extensions/Needinfo/Extension.pm
@@ +92,4 @@
>      Bugzilla->input_params($params);
>  
>      my $add_needinfo  = delete $params->{needinfo};
> +    my $needinfo_type = delete $params->{needinfo_type};

nit: add // '' to prevent uninit'd warning in string comparison.

Comment 4

[David Lawrence [:dkl]]

To https://github.com/mozilla-bteam/bmo.git
   fe64441..6d01972  master -> master