1287475 - Edit and resend will incorrectly resend modified querystring params

Status: RESOLVED WORKSFORME

(DevTools :: Netmonitor, defect, P2)

Description

[Greg Loscombe]

Attachment: firefox_querystring_edit_and_send.png

User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:47.0) Gecko/20100101 Firefox/47.0
Build ID: 20160711192800

Steps to reproduce:

- With your debug tools open, and network selected
- Goto a URL with a simple querystring, eg
https://www.google.com/textinputassistant/tia.png?hello=world
- Now click on the edit and resend
- In the panel that has the querystring, delete upto but no including the equals
(so you have "hello=")
- Now type a replacement value
- Send the result


Actual results:

- The querystring is incorrect sent.
- Upon deleting upto the =, it will put the querystring at the start of the url, followed by the first character of the value you enter, then the rest of the url, then ?
- Example, if in the above I replace hello=world with hello=blah and resent the request, it would be
hello=bhttps://www.google.com/textinputassistant/tia.png?


Expected results:

- Should correctly send the new querystring so I can make repeat requests

Comment 1

[Liviu Cirdei]

User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:50.0) Gecko/20100101 Firefox/50.0
Build ID 	20160720030208

Reproduced on latest Nightly (50.0a1) on Ubuntu 15.04 and Windows 7.

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Thanks for the report. I can see the problem on my machine too.

Honza

Comment 3

[thesamarkand]

Also, encoded in UTF-8 parameters (e. g. russian chars) will be **** up.

Comment 4

[meag.harty]

I think this bug with changing the query params is resolved. I wasn't able to reproduce it on OSX or archlinux.

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Thanks for the update. Works for me, closing.

Honza

Comment 6

[Greg Loscombe]

Verified working for me too.

62.0.3 (64bit), Fedora 28.

Thanks all
Greg