1287530 - Update FF 44/45/46/47/48 with a stub Hello add-on that removes the Hello button

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect)

Comment 1

[Mark Banner (:standard8)]

Taking, whilst I find out if we need to do a stub, or if we can just kill the add-on via a specially crafted update message.

For ESR I don't think we should do anything (it is disabled by default), unless we suspect usage there - although ESR38 we couldn't do anything about anyway.

Comment 2

[Romain Testard [:RT]]

Thanks Mark, added clarification regarding ESR in the user story. I agree we should not deal with ESR builds as part of this bug.

Comment 3

[Mark Banner (:standard8)]

Attachment: AMO addon: 2.5.0 uninstall itself.

This is an add-on that I'll upload to AMO after 49 hits. It will simply uninstall itself - so that any users who installed the "Beta" add-on will get it automatically removed.

Comment 4

[Mark Banner (:standard8)]

Attachment: Firefox System Addon v3.0.0 - disable Hello

This is an add-on that will disable Hello:

* For 44 it'll set the preference to disabled (since Hello wasn't an add-on at that time).
* For 45 - 48, it is effectively an empty add-on that will get installed over the top of the built-in add-on, or previously updated Hello system add-on. Hence, it'll disable Hello by the code effectively not being there.

Comment 5

[Mark Banner (:standard8)]

Attachment: Source files for "Firefox System Addon v3.0.0 - disable Hello"

Rob, please see comment 4 for what these files are intended to do. Can you give these a quick once-over please?

Comment 6

[Romain Testard [:RT]]

Updating user story to reflect the fact we now include FF44 users as part of this bug.

Comment 7

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Hi Mark, Sylvestre, should we relnote this in Fx48 release notes?

Comment 8

[Romain Testard [:RT]]

(In reply to Ritu Kothari (:ritu) from comment #7)
> Hi Mark, Sylvestre, should we relnote this in Fx48 release notes?

I assume we need to update release notes of FF44 through to FF48 with something similar to what we have for FF49 ("Firefox Hello being decommissioned" linking to "https://support.mozilla.org/en-US/kb/hello-status" in the "New" category?

Comment 9

[Mark Banner (:standard8)]

I've now got this up partially on the release-sysaddon channel for particular versions. I've not done 46 nor 47 yet, I've got a little bit more work to do on those.

Notes:

- For all of these, about:support should list Firefox Hello as version 3.0.0.
- On 44.* the `loop.enabled` preference will be false.
- On 45.* (not esr), 48.*, the preference is not set, as the updated version 3.0.0 (which is a bare extension) will override the built-in version of the system add-on.

Comment 10

[Mark Banner (:standard8)]

FF 46.0/46.0.1/47.0/47.0.1 should also be set up now.

Comment 11

[Sylvestre Ledru [:Sylvestre]]

I don't think we need to update old release notes because they describes a past version and it is part of history.
We should limit the update to 48 & 49 (which I just did).

Comment 12

[Mark Banner (:standard8)]

We now have 3.1.0 of the Hello add-on for 44.* and 45.* - it hides the menu option as noted per bug 1303729.

This is now on the release-sysaddon channel and ready for QA to re-test.

Comment 13

[Bogdan Maris, Desktop QA]

We finished testing 44.* and 45.* across platforms (Windows 10 64bit, Windows 7 64-bit, Mac OS X 10.11.2 and Ubuntu 16.04 32-bit), the update is successfully made to v3.1.0 and bug 1303729 was verified. 
For the other versions 46.*, 47.* and 48.*, update is made to v3.0.0 and Hello is disabled successfully.

Comment 14

[Mark Banner (:standard8)]

This is now shipping - 3.1.0 to 44 & 45, 3.0.0 to 46 through 48.