1287576 - Touch-action hit-test doesn't account for resolution on Fennec

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect, P3)

Description

[Kartikaya Gupta (email:[e-mail])]

The call at [1] is supposed to remove the resolution from the provided point, but it doesn't. It doesn't because it picks up the resolution from the root document rather than the root content document, so I think we need to add code similar to [2] on this code path.

[1] http://searchfox.org/mozilla-central/rev/bfcc10319e4e3ce78367fa9bba9316f7eb5248b6/gfx/layers/apz/util/TouchActionHelper.cpp#59
[2] http://searchfox.org/mozilla-central/rev/bfcc10319e4e3ce78367fa9bba9316f7eb5248b6/gfx/layers/apz/util/APZCCallbackHelper.cpp#567

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1287576 - Change namespace and do some formatting cleanup for TouchActionHelper.

Review commit: https://reviewboard.mozilla.org/r/66512/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/66512/

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1287576 - Extract a helper method to update a frame to the touch target document's root frame. No functional changes.

Review commit: https://reviewboard.mozilla.org/r/66514/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/66514/

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1287576 - Update the touch-behavior notification code to behave like the set-target-apzc notification code.

In particular, this change uses the root frame of the touch target document,
so that the correct presShell resolution is used when doing the touch-action
hit test.

Review commit: https://reviewboard.mozilla.org/r/66516/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/66516/

Comment 4

[Kartikaya Gupta (email:[e-mail])]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=03ce7b5295c7&group_state=expanded

Comment 5

[Botond Ballo [:botond]]

Comment on attachment 8773854 [details]
Bug 1287576 - Change namespace and do some formatting cleanup for TouchActionHelper.

https://reviewboard.mozilla.org/r/66512/#review63704

Comment 6

[Botond Ballo [:botond]]

Comment on attachment 8773855 [details]
Bug 1287576 - Extract a helper method to update a frame to the touch target document's root frame. No functional changes.

https://reviewboard.mozilla.org/r/66514/#review63708

Comment 7

[Botond Ballo [:botond]]

Comment on attachment 8773856 [details]
Bug 1287576 - Update the touch-behavior notification code to behave like the set-target-apzc notification code.

https://reviewboard.mozilla.org/r/66516/#review63710

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a6c01c25609d
Change namespace and do some formatting cleanup for TouchActionHelper. r=botond
https://hg.mozilla.org/integration/mozilla-inbound/rev/77c13c4140a4
Extract a helper method to update a frame to the touch target document's root frame. No functional changes. r=botond
https://hg.mozilla.org/integration/mozilla-inbound/rev/5adee976c6cc
Update the touch-behavior notification code to behave like the set-target-apzc notification code. r=botond

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a6c01c25609d
https://hg.mozilla.org/mozilla-central/rev/77c13c4140a4
https://hg.mozilla.org/mozilla-central/rev/5adee976c6cc