1287760 - Comment out AddEventListenerOptions.once

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Andrea Marchesini [:baku]]

Attachment: once.patch

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8772388 [details] [diff] [review]
once.patch

And one ESR we need also passive commented out, right?

It was implemented in https://bugzilla.mozilla.org/show_bug.cgi?id=1266066

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7bfa8f091fcc
Comment out AddEventListenerOptions.once, r=smaug

Comment 3

[Andrea Marchesini [:baku]]

Attachment: esr-45

[Approval Request Comment]
If this is not a sec:{high,crit} bug, please state case for ESR consideration:
User impact if declined: feature detection.
Fix Landed on Version: current m-i
Risk to taking this patch (and alternatives if risky):  none
String or UUID changes made by this patch:  none

See https://wiki.mozilla.org/Release_Management/ESR_Landing_Process for more info.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

We need the patch on 49 too.

Comment 5

[Xidorn Quan [:xidorn] UTC+11]

How does a field of dictionary feature-detectable?

Comment 6

[Xidorn Quan [:xidorn] UTC+11]

Errr... I mean how can a field of dictionary be feature-detectable?

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

 document.addEventListener("foo", function() {}, { get once() { throw "foo" }});

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7bfa8f091fcc

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Baku, I am sorry but I need subtitle to understand why you want this into esr as his is not a sec issue.

Comment 10

[Andrea Marchesini [:baku]]

Smaug, can you help me with this?

Comment 11

[Olli Pettay [:smaug][[e-mail]]]

We broke feature testing on esr (and elsewhere) when landing the patch which didn't have review comments fixed
https://bugzilla.mozilla.org/show_bug.cgi?id=1266194#c5

Comment 12

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8772400 [details] [diff] [review]
esr-45

Improve the webcompat support of esr45, taking it.

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-esr45/rev/6b17b640955d