1287875 - Logging for intercepted COM traffic

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[(No longer employed by Mozilla) Aaron Klotz]

This patch facilitates logging of COM traffic in both the parent and sandboxed child processes. It will be used by the forthcoming COM interceptor.

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Bug 1287875: Adds a logging facility for intercepted COM traffic;

Review commit: https://reviewboard.mozilla.org/r/65292/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/65292/

Comment 2

[Jim Mathies [:jimm]]

Comment on attachment 8772498 [details]
Bug 1287875: Adds a logging facility for intercepted COM traffic;

https://reviewboard.mozilla.org/r/65292/#review62976

Might be nice if we could filter the QI logging from this. I found it occupies 90% of the log data when testing with a touch screen.  Regardless, not going to hold this up for that.

Comment 3

[(No longer employed by Mozilla) Aaron Klotz]

I'll file a followup.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2eaabe71dd10
Adds a logging facility for intercepted COM traffic; r=jimm

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2eaabe71dd10

Comment 6

[aleth [:aleth]]

NS_APP_CONTENT_PROCESS_TEMP_DIR should only be used if MOZ_CONTENT_SANDBOX is set, cfhttps://dxr.mozilla.org/comm-central/source/mozilla/xpcom/io/nsAppDirectoryServiceDefs.h#87.

Currently this is not the case in https://hg.mozilla.org/mozilla-central/rev/2eaabe71dd10#l1.100 (noticed as it is causing failures on c-c).

Comment 7

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Build fix for when MOZ_CONTENT_SANDBOX is not defined

Whoops. Considering that I initially wrote NS_APP_CONTENT_PROCESS_TEMP_DIR, I should have known better!

Comment 8

[(No longer employed by Mozilla) Aaron Klotz]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3a248e721aa179549a8b5a7b78c0ac8fed4603be
Bug 1287875: Don't try to obtain NS_APP_CONTENT_PROCESS_TEMP_DIR unless MOZ_CONTENT_SANDBOX is defined; r=haik

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3a248e721aa1

Comment 10

[Jorg K (CEST = GMT+2)]

Thanks for the quick fix. We (TB) can now compile again ;-)